Last Comment Bug 842003 - Leak-check ipc/chromium stuff
: Leak-check ipc/chromium stuff
Status: NEW
[MemShrink:P2]
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: unspecified
: x86_64 Linux
: P3 normal with 1 vote (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-15 23:23 PST by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2013-05-14 22:06 PDT (History)
12 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2013-02-15 23:23:49 PST
See bug 841993 for the disaster the lack of this caused; without DMD, we would have been in a really bad spot.

The reason this stuff isn't leak checked is
 - in original and current desktop usage, we only hold onto one class there explicitly, the child process host.  Everything else is managed by it.
 - it's not moz code, sorta

But now with |opens| and |bridge| channels, we drag IPC:Channel out of ipc/chromium.  We were leaking those for ages and didn't know it.

Easiest thing to do is just let the moz code start trickling in there, starting with COUNT_CTOR/COUNT_DTOR.
Comment 1 Ben Turner (not reading bugmail, use the needinfo flag!) 2013-02-16 08:25:43 PST
We currently have [1]:

  typedef IPC::Channel Transport;

We could just inherit into our own class that adds logging instead.
Comment 2 Ben Turner (not reading bugmail, use the needinfo flag!) 2013-02-16 08:25:55 PST
Oops, that is in http://mxr.mozilla.org/mozilla-central/source/ipc/glue/Transport.h#24
Comment 3 Jet Villegas (:jet) 2013-05-14 14:55:47 PDT
bent: Will a leak reporter here help real leaks (ie. non-leak on shutdown?)
Comment 4 Ben Turner (not reading bugmail, use the needinfo flag!) 2013-05-14 15:14:03 PDT
Hm, not sure I understand the question. We definitely had real leaks that were not reclaimed at shutdown. We never saw them because these classes aren't instrumented.
Comment 5 Justin Lebar (not reading bugmail) 2013-05-14 22:06:22 PDT
> We definitely had real leaks that were not reclaimed at shutdown.

Okay, that was the question.  Thanks.

Note You need to log in before you can comment on or make changes to this bug.