Closed Bug 84209 Opened 21 years ago Closed 10 years ago

window onclose handlers need love

Categories

(SeaMonkey :: MailNews: Message Display, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: danm.moz, Unassigned)

Details

(Whiteboard: [waiting for comment 2 answer] [patchlove] [2012 Fall Equinox])

Attachments

(1 file)

As we were discussing, window onload handlers should return a value: if true, 
the window is closed automatically; if false it isn't (I think I got that 
right). Several onclose handlers in Mozilla are returning unspecified values, 
and several are closing the window themselves (which is guarded against, so it 
doesn't hurt, but it is unnecessary and not -- strictly speaking -- correct.)

I'll attach a patch that I was working on recently when I thought I was going to 
have to fix this. I'm not saying it's all correct, but it addresses all the 
problems I could find. Maybe you want to be the first owner, and hand it along, 
or maybe, heck, you just want to hand this bug back to me.
Dan, may I ask what this helps? Does it fix anything in particular, or is it
just stupid me? :)
QA Contact: esther → stephend
Product: Browser → Seamonkey
Assignee: sspitzer → mail
Assignee: mail → nobody
QA Contact: stephend → message-display
This bug is being marked EXPIRED as it has seen no activity in a very long time.

If you think that the issue reported might still be relevant, please test with a recent release of SeaMonkey and if the problem persists feel free to re-open the report. Thank you.

http://www.seamonkey-project.org/
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → EXPIRED
Bulk reopening incorrectly expired bugs - no activity does not constitute no bug - these need proper checking.
Status: RESOLVED → REOPENED
Resolution: EXPIRED → ---
Status: REOPENED → NEW
Whiteboard: [patchlove]
Whiteboard: [patchlove] → [waiting for comment 2 answer] [patchlove]
Sadly, I cannot provide any additional insight here, because I'm not the "Dan M" in question -- that's Dan Matejka.
This bug is being closed INCOMPLETE for lack of an answer to comment #2 more than 3 years after it was requested from the reporter in the Whiteboard.

Feel free to REOPEN with a comment providing the requested information.
Status: NEW → RESOLVED
Closed: 14 years ago10 years ago
Resolution: --- → INCOMPLETE
Whiteboard: [waiting for comment 2 answer] [patchlove] → [waiting for comment 2 answer] [patchlove] [2012 Fall Equinox]
You need to log in before you can comment on or make changes to this bug.