842131 - Bug 840512 assumes gnu grep extension - breaks clang/bsd builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Landry Breuil (:gaston)]

clang builds on bsd now fail at configure with :

configure: error: Only GCC 4.4 or newer supported

Bug 840512 adds a check on clang version assuming GNU grep is used :

$clang -v
clang version 3.2 (tags/RELEASE_32/final)
Target: amd64-unknown-openbsd5.3
Thread model: posix

$clang -v 2>&1 | grep -c 'clang version\|Apple.*clang'
0

two alternatives that work :

$clang -v 2>&1 | ggrep -c 'clang version\|Apple.*clang'
1

$clang -v 2>&1 | egrep -c '(clang version|Apple.*clang)'
1

Comment 1

[Landry Breuil (:gaston)]

The latter might be the best fix, since gnu grep called as gegrep produces the same result as bsd egrep :

$clang -v 2>&1 | gegrep -c '(clang version|Apple.*clang)'
1

I'll provide a patch when it's confirmed being the best fix by a build-system hacker :)

Comment 2

[Landry Breuil (:gaston)]

https://tbpl.mozilla.org/?tree=Try&rev=7b0b0b9012ba tries the egrep -c '(a|b)' variant

Comment 3

[Landry Breuil (:gaston)]

Attachment: use egrep where appropriate

All green on try, and after a quick look with mxr it looks like egrep is already commonly used in configure.in - so let's go for this version.

Comment 4

[Landry Breuil (:gaston)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4a233c10cc9

Comment 5

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/b4a233c10cc9