842143 - [Gallery] sharing image button does not work: TypeError: blob is undefined

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Tony Chung [:tchung]]

Unable to tap on a photo and share within gallery.   Blob is undefined error thrown.

This used to work just fine; regression.


Logcat
02-17 09:11:44.692: E/GeckoConsole(1042): [JavaScript Error: "TypeError: blob is undefined" {file: "app://gallery.gaiamobile.org/js/gallery.js" line: 829}]

REpro:
1) install unagi 101 nightly build
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/059a7e0badf7
Gaia   4164424049f9caa4e6b26aefe3a4fa7421451b2b
BuildID 20130217070201
Version 18.0
2) launch gallery, and tap on an existing photo
3) in gallery menu, click the share icon
4) Verify nothing happens, and blob is undefined error

Expected:
- sharing launch picker is thrown

ActuaL:
- nothing, no response

Comment 1

[Tony Chung [:tchung]]

I should note that i have *not* pre-setup my email account yet.   I do however, have bluetooth transfer enabled.

Comment 2

[David Flanagan [:djf]]

I can reproduce this. I'm guessing I busted something with my big patch for bug 837236 and didn't test sufficiently.  We should try to get the fix for this into 1.0.1 as well, shouldn't we?

Does it need a shira+ flag as well?

Comment 4

[Tony Chung [:tchung]]

(In reply to David Flanagan [:djf] from comment #2)
> I can reproduce this. I'm guessing I busted something with my big patch for
> bug 837236 and didn't test sufficiently.  We should try to get the fix for
> this into 1.0.1 as well, shouldn't we?
> 
> Does it need a shira+ flag as well?

sounds about right, but how do i add a blocking-b2g=shira+ flag?   my bugzilla options only allow for one entry; and thats taken tef+ up.

Comment 5

[mdaniloff]

While working to find the regression window, I tested the nightly builds and observed the issue reproduced all the way back to the Feb 16th build.

Comment 6

[David Flanagan [:djf]]

Attachment: link to patch on github

Dale,

This bug is a regression from bug 837236 which included a lot of changes to shared/js/media/media_frame.  One of those changes removed the blob property of the MediaFrame object and replaced it with separate imageblob, videoblob and posterblob properties.

I didn't test gallery sufficiently for that bug, so this patch now modifies gallery to use imageblob and videoblob instead of blob.

Comment 7

[Dale Harvey (:daleharvey)]

Comment on attachment 716108 [details]
link to patch on github

Merged in: https://github.com/mozilla-b2g/gaia/commit/0d9c993cccfc7c827f56d00a5eb360dd2f816ab5

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train@07be91c6544030394a955b00f3afe8f5f6d57dd1
v1.0.1@27ac754a993581f45dff7634473a46b0ecd1c4b3

Comment 9

[Jason Smith [:jsmith]]

Going to find a new assignee to the verification.

Comment 10

[J Zimbrick]

Issue no longer appears to be occurring on an Unagi device running the following build:

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/406b86b4b515
Gaia: c5a8b6476f0dbc456061227a7801e56634683eb0
Build: 20130319070203

Tapping the share button brings up various options for the user to share a photo.

Verifying as fixed.