B2G CDMA: [Gaia] Add signal notification function for CDMA/EVDO network

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: kchang, Assigned: arthurcc)

Tracking

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:koi+)

Details

(Whiteboard: [UX ETA:9/6], [FT:RIL], [Sprint:4])

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
For supporting the signal notification function of CDMA/Evdo, Gaia has to read the new signal information from RIL for CDMA/EVDO network.
(Reporter)

Updated

6 years ago
No longer blocks: 835237
(Reporter)

Updated

6 years ago
Blocks: 835237
(Reporter)

Comment 1

6 years ago
For GSM network, we should modify following code

icon.dataset.level = Math.ceil(voice.relSignalStrength / 20); // 0-5

to be
        if (voice.signal.gsmSignal >= -86) {
          icon.dataset.level = 5;
        } else if (voice.signal.gsmSignal >= -88) {
          icon.dataset.level = 4;
        } else if (voice.signal.gsmSignal >= -97) {
          icon.dataset.level = 3;
        } else if (voice.signal.gsmSignal >= -102) {
          icon.dataset.level = 2;
        } else if (voice.signal.gsmSignal >= -108) {
          icon.dataset.level = 1;
        } else {
          icon.dataset.level = 0;
        }
(Reporter)

Comment 2

6 years ago
And the |relSignalStrength| have been removed from DOM API.
the |signalStrength| have been moved to |signal.gsmSignal|
(Reporter)

Updated

6 years ago
No longer blocks: 835237
Depends on: 835237

Updated

5 years ago
Blocks: 890325
blocking-b2g: --- → koi+

Comment 3

5 years ago
Neo, we need the UX design for this item. Thanks!
Assignee: rexboy → nhsieh

Comment 4

5 years ago
(In reply to Ken Chang from comment #1)
> For GSM network, we should modify following code
> 
> icon.dataset.level = Math.ceil(voice.relSignalStrength / 20); // 0-5
> 
> to be
>         if (voice.signal.gsmSignal >= -86) {
>           icon.dataset.level = 5;
>         } else if (voice.signal.gsmSignal >= -88) {
>           icon.dataset.level = 4;
>         } else if (voice.signal.gsmSignal >= -97) {
>           icon.dataset.level = 3;
>         } else if (voice.signal.gsmSignal >= -102) {
>           icon.dataset.level = 2;
>         } else if (voice.signal.gsmSignal >= -108) {
>           icon.dataset.level = 1;
>         } else {
>           icon.dataset.level = 0;
>         }
Ken, can we not keep this logic in RIL as it is now and just use the relSignalStrength? All gaia needs to know is how many signal strength bars to display and that it already does based on relSignalStrenth. RIL can figure out for each network GSM/CDMA/Evdo and then calculate the rilSignalStrength and send it to Gaia.

Updated

5 years ago
QA Contact: echu

Updated

5 years ago
Whiteboard: [UX ETA:9/6]

Updated

5 years ago
Whiteboard: [UX ETA:9/6] → [UX ETA:9/6], [FT:RIL], [Sprint:4]
(Reporter)

Comment 5

5 years ago
(In reply to Anshul from comment #4)
> Ken, can we not keep this logic in RIL as it is now and just use the
> relSignalStrength? All gaia needs to know is how many signal strength bars
> to display and that it already does based on relSignalStrenth. RIL can
> figure out for each network GSM/CDMA/Evdo and then calculate the
> rilSignalStrength and send it to Gaia.
Hi Anshul, sure. And Edgar have done what your said.

Comment 6

5 years ago
Created attachment 796462 [details]
CDMA_Signal_icon.zip

Please check attached file.
(Reporter)

Comment 7

5 years ago
Arthur, can you please help?
Assignee: nhsieh → arthur.chen
In bug 878851 we changed the technology icon from png to characters.
Created attachment 797717 [details]
link to https://github.com/mozilla-b2g/gaia/pull/11855

Alive, could you help review this change? Thanks!
Attachment #797717 - Flags: review?(alive)
Attachment #797717 - Flags: review?(alive) → review+
Thanks alive!

master: https://github.com/mozilla-b2g/gaia/commit/ce41a1f6680eaf4395a8bfcb7457f1d9bbfd6267
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.