842221 - [Settings][Data Roaming] After 1st warning when you enable "data roaming"

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Walter Chen[:ypwalter][:wachen]]

*Unagi

*Build Version: 
PVT nightly b2g18 user build
https://pvtbuilds.mozilla.org/pub/mozilla.org/b2g/nightly/mozilla-b2g18-unagi/2013/02/2013-02-17-07-02-02/

*STR:
Please follow the test cases:
https://moztrap.mozilla.org/manage/case/6203/
It should fail on 4th test step

Or, here is brief version of reproduction steps -
  1. Flash your phone
  2. Go to "Settings" app
  3. Go to "Cellular & Data" section
  4. Enable "Data connection"
  5. Enable "Data roaming"
  6. Choose "Not now"

*Expected Result:
  It should not show that "Data roaming" is enabled

*Actual Result:
  It shows that "Data roaming" is enabled.
  But, one good thing is that it doesn't really get data roaming...
  Just the UI shows that it is enabled.
  However, this should still be corrected.

Comment 1

[Arthur Chen [:arthurcc][inactive after 6/30]]

This should be shira+ because the feature is broken.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/8162

Chris, could you help review the change? It corrects the reference to the settings object. Thanks!

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 715066 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/8162

Remove the review flag. Need to provide another patch for the exception of accessing the settings object.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Fixed with the patch in bug 840322.

Comment 7

[Walter Chen[:ypwalter][:wachen]]

Verified fixed in 2013/02/24 pvt pub b2g18 build