842239 - B2G Multi-SIM: get the number of RadioInterfaces

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Figure out how DOM/gaia gets the number of sim cards.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #0)
> Figure out how DOM/gaia gets the number of sim cards.

In gaia, always using navigator.mozMobileConnections.length.
In DOM/RIL, using 'nsIRadioInterfaceLayer.numRadioInterfaces.' Patch is on the way.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: 842239.patch

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 812953 [details] [diff] [review]
842239.patch

Review of attachment 812953 [details] [diff] [review]:
-----------------------------------------------------------------

Per offline discuss, we may still have racing condition in child process.  Perfect solution should be deprecate RILContentHelper and move all IPC to IPDL (bug 815526).

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #3)
> Comment on attachment 812953 [details] [diff] [review]
> 842239.patch
> 
> Review of attachment 812953 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Per offline discuss, we may still have racing condition in child process. 
> Perfect solution should be deprecate RILContentHelper and move all IPC to
> IPDL (bug 815526).

Yes, I agree!!!

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3959aecea555

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3959aecea555

Comment 7

[Kai-Chih Hu [:khu]]

This blocked more than one 1.3+ bugs. Marked this as 1.3+.