Closed
Bug 842369
Opened 12 years ago
Closed 12 years ago
Profile provider should be robust against stat failure
Categories
(Firefox Health Report Graveyard :: Client: Desktop, defect)
Firefox Health Report Graveyard
Client: Desktop
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 21
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #715226 -
Flags: review?(gps)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 715226 [details] [diff] [review]
Trivial patch. v1
Review of attachment 715226 [details] [diff] [review]:
-----------------------------------------------------------------
::: services/healthreport/profile.jsm
@@ +162,2 @@
> return OS.File.stat(entry.path)
> + .then(onStatSuccess, onStatFailure);
I fail to see how this solves anything. Won't the rejected promise cascade into the DirectoryIterator.forEach promise chain?
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 715226 [details] [diff] [review]
Trivial patch. v1
Review of attachment 715226 [details] [diff] [review]:
-----------------------------------------------------------------
After IRC confirmation.
Attachment #715226 -
Flags: review?(gps) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Target Milestone: --- → mozilla21
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla21 → Firefox 21
|
||
Updated•6 years ago
|
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•