Closed Bug 842369 Opened 7 years ago Closed 7 years ago

Profile provider should be robust against stat failure

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 21

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #715226 - Flags: review?(gps)
Comment on attachment 715226 [details] [diff] [review]
Trivial patch. v1

Review of attachment 715226 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/healthreport/profile.jsm
@@ +162,2 @@
>        return OS.File.stat(entry.path)
> +                    .then(onStatSuccess, onStatFailure);

I fail to see how this solves anything. Won't the rejected promise cascade into the DirectoryIterator.forEach promise chain?
Comment on attachment 715226 [details] [diff] [review]
Trivial patch. v1

Review of attachment 715226 [details] [diff] [review]:
-----------------------------------------------------------------

After IRC confirmation.
Attachment #715226 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/f992507bf218
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: Metrics and Firefox Health Report → Client: Desktop
Product: Mozilla Services → Firefox Health Report
Target Milestone: mozilla21 → Firefox 21
Product: Firefox Health Report → Firefox Health Report Graveyard
You need to log in before you can comment on or make changes to this bug.