842374 - Use GeckoAsyncTask instead of AsyncTask when removing bookmarks

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

When removing a bookmark we execute DB code in some background thread that is not GeckoBackgroundTread. We could easily use GeckoBackgroundThread if the code switched to GeckoAsyncTask, but it does not support "onPreExecute" so it is not a drop in replacement.

This patch adds a simple "onPreExecute" to GeckoAsyncTask and replaces AsyncTask when removing a bookmark.

Like AsyncTask, I am calling onPreExecute on whatever thread creates GeckoAsyncTask.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Note to self: Remember to remove the AsyncTask import

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 715220 [details] [diff] [review]
patch

Review of attachment 715220 [details] [diff] [review]:
-----------------------------------------------------------------

So this seems wrong to me; the general contract of GeckoAsyncTask is that it behaves like AsyncTask, except that it forces the UI thread in place of "whatever random thread the task is created on and/or calls execute()". Which means that onPreExecute() should also always run on the UI thread, rather than the thread that calls execute().

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch 2

This patch ensures onPreExecute is run on the UI thread

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 715600 [details] [diff] [review]
patch 2

Review of attachment 715600 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Kartikaya Gupta (email:[e-mail])]

CCing bnicholson as well since one of you will need to rebase for the s/Activity/Handler/ changes.

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/208b826dc3d3

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/208b826dc3d3