Closed Bug 842395 Opened 10 years ago Closed 10 years ago

Remove areClientsAvailable() from TabsAccessor

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 22

People

(Reporter: bnicholson, Assigned: bnicholson)

References

Details

Attachments

(1 file)

Remove areClientsAvailable() from TabsAccessor
2.52 KB, patch
mfinkle
: review+
Details | Diff | Splinter Review 
We aren't using this method anywhere.
Attachment #715256 - Flags: review?(mark.finkle)
I also removed the unused OnClientsAvailableListener interface locally.
Attachment #715256 - Flags: review?(mark.finkle) → review+
Have you talked to rnewman about whether or not sync needs this?
(In reply to :Margaret Leibovic from comment #2)
> Have you talked to rnewman about whether or not sync needs this?

I didn't see it used in the sync code either, but I guess it couldn't hurt to ask.
Flags: needinfo?(rnewman)
Looking through the history here a bit more, I think you're right that we don't need this anymore. I had just remembered working with rnewman on TabsAccessor, so I recalled some sync dependency. Never hurts to ask through! :)
Thanks, Margaret, Brian!

This used to be used in TabsTray to hide or show the remote tabs UI (Bug 734425). Looks like it's dead code now.

Yay for shrinkage!
Status: NEW → ASSIGNED
Depends on: 734425
Flags: needinfo?(rnewman)
Target Milestone: --- → Firefox 22
https://hg.mozilla.org/mozilla-central/rev/b7863019511c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.