842395 - Remove areClientsAvailable() from TabsAccessor

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Attachment: Remove areClientsAvailable() from TabsAccessor

We aren't using this method anywhere.

Comment 1

[Brian Nicholson (:bnicholson)]

I also removed the unused OnClientsAvailableListener interface locally.

Comment 2

[:Margaret Leibovic]

Have you talked to rnewman about whether or not sync needs this?

Comment 3

[Brian Nicholson (:bnicholson)]

(In reply to :Margaret Leibovic from comment #2)
> Have you talked to rnewman about whether or not sync needs this?

I didn't see it used in the sync code either, but I guess it couldn't hurt to ask.

Comment 4

[:Margaret Leibovic]

Looking through the history here a bit more, I think you're right that we don't need this anymore. I had just remembered working with rnewman on TabsAccessor, so I recalled some sync dependency. Never hurts to ask through! :)

Comment 5

[Richard Newman [:rnewman]]

Thanks, Margaret, Brian!

This used to be used in TabsTray to hide or show the remote tabs UI (Bug 734425). Looks like it's dead code now.

Yay for shrinkage!

Comment 6

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b7863019511c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b7863019511c