84241 - Need to disable auto-launch of helper apps by pref

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P1)

Description

[Phil Peterson]

For unfortunate reasons, Netscape needs our commercial builds to ask users
before launching helper apps for files downloaded from web servers. The reasons
are outlined in http://bugscape.mcom.com/show_bug.cgi?id=5503 and
[e-mail] understands them.

For mozilla builds, we turn this misfeature off by default, leaving the current
behavior in place. So mozilla users can auto-launch apps.

Comment 1

[Phil Peterson]

Attachment: patch from bugscape 5503

Comment 2

[Phil Peterson]

mscott sr'd. asa approved. need r= 

Comment 3

[Viswanath Ramachandran]

r=vishy. this is now good to go in. 

Comment 4

[selmer (gone)]

Phil and I pre-cleared this with Asa, please check in when ready.

Comment 5

[Scott MacGregor]

i didn't sr the latest patch that samir posted so it shouldn't say sr=mscott yet =).

I have some comments:
1) can you remove the dump statement
2) can you remove the empty function you added called: getForceAlwaysAskPref()
3) It probably doesn't matter much but I wonder if we should default the
initialization of alwaysAsk to PR_TRUE instead of false just in case
mMimeInfo->GetAlwaysAskBeforeHandling returns an error for some un-expected
reason.  Better to err on the side of caution in such a scenario.

sr=mscott 

Comment 6

[Samir Gehani]

Scott,
Already addressed 1 and 2.  I gave item 3 some thought but was not sure what the
rationale for initializing it to false was.  I agree with the argument we should
err on the side of caution.  Will incorporate the latter into the next patch and
will assume the r, sr, a unless someone feels strongly about seeing the next rev
of the patch.

Comment 7

[Samir Gehani]

Checked in to both trunk and branch.  Mozilla will remain unaffected since the
pref "browser.helperApps.alwaysAsk.force" defaults to false for mozilla.

Comment 8

[Blake Ross]

+        gAskBeforeOpen.checked = handlerInfo.alwaysAsk == "true" ? true : 
false;


What's the point of the unnecessarily complex ternary operator?  Why not just 
gAskBeforeOpen.checked = handlerInfo.alwaysAsk == "true"?