84259 - Properties dialog: links should appear underlined [or, some sort of formatting] in modern

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[sairuh (rarely reading bugmail)]

couldn't find an existing a bug for this, but do dup and/or reassign as needed.
basically, the links which appear in the Properties dialog [whether for links or
images] are unformatted, ie, has the same appearance as the rest of the content
in that dialog. perhaps the link should be underlined and/or colored? eg,
perhaps use the same color/appearance styles as links in the browser?

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

It seems like the new modern are missing the "link" class I added to modern2 
and classic when I did the properties window.

Comment 2

[Gervase Markham [:gerv]]

Any particular links? This WORKSFORME in 2001-05-25 Win95...

Oh, I see. Jonas - do you want to sort this out? I'm rather tied up right now...

Gerv

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

CC'ing hewitt since he's the creator of modern3. Hewitt, the new modern is 
missing the "link" class that I added when doing the properties window. The 
patches for that is avalible in bug 1995

Comment 4

[sairuh (rarely reading bugmail)]

example:

1. go to http://faqs.org/
2. bring up the Properties dialog for either the library image in the main
frame, or the "no frames" image link in the left nav frame.

yep, i see this with modern3, not with classic. [in classic the links are blue.]
thx for pointing this out, jonas!

should this go over to the themes folx?

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

IMHO it should. Assigning -> themes

Comment 6

[Joe Hewitt (gone)]

There has long been a class in the Modern and Classic themes called "text-link".
 Jonas, you should have used this in your XUL instead of "link".  I'm not going
to add the "link" class, since it is redundant.

Please change your xul to use "text-link" and remove the "link" class from the
places you added it in Classic.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Attachment: patch to remove my .link class and have the properties window use the .text-link class

Comment 8

[Håkan Waara]

You tested it that it works, right?  r=hwaara

Comment 9

[Joe Hewitt (gone)]

sr=hewitt

Comment 10

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

checked in

Comment 12

[Patty Mac]

Verified the patch.