842618 - SeaMonkey contains PrivateBrowsingUtils.jsm, but it throws an exception if used

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Michael Kraft [:morac]]

The trunk (2.18a1 branch) version of SeaMonkey added the resource://gre/modules/PrivateBrowsingUtils.jsm, but because SeaMonkey doesn't support Private Browsing, referencing PrivateBrowsingUtils.permanentPrivateBrowsing throws the following exception:

Tue Feb 19 2013 11:58:51
Error: NS_ERROR_UNEXPECTED: Component returned failure code: 0x8000ffff (NS_ERROR_UNEXPECTED) [nsIPrefBranch.getBoolPref]
Source file: resource://gre/modules/PrivateBrowsingUtils.jsm
Line: 31

since the browser.privatebrowsing.autostart preference does not exist in SeaMonkey.


My add-on assumes that if PrivateBrowsingUtils.jsm exists, then it works.  As such it is not broken in the nightly SeaMonkey loads until I add try/catches around all calls to PrivateBrowsingUtils.jsm.

If Private Browsing isn't supported, SeaMonkey should not include the PrivateBrowsingUtils.jsm module.

Comment 1

[Philip Chee]

> The trunk (2.18a1 branch) version of SeaMonkey added the resource://gre/modules
> /PrivateBrowsingUtils.jsm, but because SeaMonkey doesn't support Private Browsing,
> referencing PrivateBrowsingUtils.permanentPrivateBrowsing throws the following
> exception:

Experimental private browsing was checked in to comm-central about three or four days ago so per window Private Browsing is supported. We could of course add "pref("browser.privatebrowsing.autostart", false);" to our browser-prefs.js

Comment 2

[Philip Chee]

Attachment: Patch v1.0 add browser.privatebrowsing.autostart to browser-prefs.js

This pref adds the "browser.privatebrowsing.autostart" pref to our browser-prefs.js for extension-compat

Comment 3

[Philip Chee]

Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/ddd02164f9f7

Comment 4

[Philip Chee]

Michael; Just to note that with this patch PrivateBrowsingUtils won't throw. But nothing in SeaMonkey ever sets this to true.

Comment 5

[Michael Kraft [:morac]]

(In reply to Philip Chee from comment #4)
> Michael; Just to note that with this patch PrivateBrowsingUtils won't throw.
> But nothing in SeaMonkey ever sets this to true.

That's fine.

Comment 6

[[e-mail]]

(In reply to Philip Chee from comment #4)
> Michael; Just to note that with this patch PrivateBrowsingUtils won't throw.
> But nothing in SeaMonkey ever sets this to true.

And if someone does set it to true then SeaMonkey will probably stop working properly.

Comment 7

[(no longer active)]

Note bug 845341.  It was a bug in the toolkit code to assume this pref always exists.

Comment 8

[Philip Chee]

Note to self: Back out this patch once Bug 845341 is fixed
[PrivateBrowsingUtils.permanentPrivateBrowsing can throw if the autostart pref does not exist]

Comment 9

[Philip Chee]

Attachment: Backout Patch r=Neil over IRC

Now that Bug 845341 is fixed this can be backed out.

Backout changeset:
http://hg.mozilla.org/comm-central/rev/8b8ff0fc1c16

Comment 10

[Philip Chee]

Comment on attachment 717525 [details] [diff] [review]
Patch v1.0 add browser.privatebrowsing.autostart to browser-prefs.js

Cancelling review request