Closed Bug 842683 Opened 11 years ago Closed 11 years ago

JavaScript strict warning: chrome://reftest/content/reftest.js, line 1057: reference to undefined property CC['@mozilla.org/widget/macdocksupport;1']

Categories

(Testing :: Reftest, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(1 file)

All of our Linux (and probably all non-mac) debug reftest runs start with this:
{
JavaScript strict warning: chrome://reftest/content/reftest.js, line 1057: reference to undefined property CC['@mozilla.org/widget/macdocksupport;1']
}

I see this in my local reftest runs, as well as in runs on TBPL like e.g.
https://tbpl.mozilla.org/php/getParsedLog.php?id=19880669&tree=Mozilla-Inbound 

This is from some Mac-specific code in reftest.js that was added in bug 623625.

We shouldn't let this mac-specific check spam up all the other platforms.
Can we use #ifdef in reftest.js? I noticed that we've got e.g. "#ifdef XP_MACOSX" in browser.js:
 https://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#1877

If that works in reftest.js, that's probably what we want here as well.
Component: General → Reftest
Product: Core → Testing
Hardware: x86_64 → All
We can use #ifdef, given the * in front of reftest.js in the jar.mn in that directory, which notes it as a file to be preprocessed.  Just remember the set of things that we can switch on are those that our build system defines (e.g., with AC_DEFINE), not those that the C++ compiler or NSPR define.
Attached patch fix v1Splinter Review
Yup, that seems to work. Here's the patch for that.

Here's a green try push testing that, w/ an additional gDumpLog() invocation in that mac-specific chunk, which verifies that it's there on mac but not on linux:
  https://tbpl.mozilla.org/?tree=Try&rev=2aec6816394e

The mac reftest logs there show the dump, to prove that the #ifdef is being entered on mac.  The dump looks like this:
> REFTEST INFO | ********************* Doing mac-specific dock stuff
Sample logs, showing that:
https://tbpl.mozilla.org/php/getParsedLog.php?id=19931608&tree=Try
https://tbpl.mozilla.org/php/getParsedLog.php?id=19930371&tree=Try

but the linux log doesn't contain that dump (as expected):
 https://tbpl.mozilla.org/php/getParsedLog.php?id=19931681&tree=Try
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #716361 - Flags: review?(dbaron)
Flags: in-testsuite-
https://hg.mozilla.org/mozilla-central/rev/7a332016b950
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.