842716 - Should report Gecko version in SDP

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Timothy B. Terriberry (:derf)]

It would be helpful for debugging if we reported the current Firefox version in our SDP.

Comment 1

[Adam Roach [:abr]]

Attachment: Include UA version number in SDP o= line

Comment 2

[Adam Roach [:abr]]

Let's make sure there aren't any hidden gotchas here:

https://tbpl.mozilla.org/?tree=Try&rev=a78b859e3299

Comment 3

[Adam Roach [:abr]]

I'm not sure I'd call this one blocking release. It's really more of a "nice to have when troubleshooting" kind of thing.

Comment 4

[Maire Reavy [:mreavy]]

(In reply to Adam Roach [:abr] from comment #3)
> I'm not sure I'd call this one blocking release. It's really more of a "nice
> to have when troubleshooting" kind of thing.

Yeah, I was on the fence about whether to make this blocking.  We *should* report the Gecko version, but if you feel strongly that we should demote this, I can live with that.  Is the patch on this bug ready to land?  (It looks like it is.)

Comment 5

[Adam Roach [:abr]]

Apparently, the preprocessor macro I used to make this happen isn't available on Windows. It seemed like an easy fix when I wrote the patch, but this turns it into more of a research project. Given the relative invisibility of this change, I figured I could let it sit on a back burner for a while.

Comment 6

[Maire Reavy [:mreavy]]

(In reply to Adam Roach [:abr] from comment #5)
> Apparently, the preprocessor macro I used to make this happen isn't
> available on Windows. It seemed like an easy fix when I wrote the patch, but
> this turns it into more of a research project. Given the relative
> invisibility of this change, I figured I could let it sit on a back burner
> for a while.

Thanks for the info.  I agree with you -- we should fix it when we can, but not block on it.

Comment 7

[Adam Roach [:abr]]

Huh. A second look at the oranges from that earlier try makes me think that the error might have been unrelated to this patch. I'll give this another spin and see if it's actually okay.

Comment 8

[Adam Roach [:abr]]

https://tbpl.mozilla.org/?tree=Try&rev=7bd449f9e9cd

Comment 9

[Adam Roach [:abr]]

Comment on attachment 715660 [details] [diff] [review]
Include UA version number in SDP o= line

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d475649f83d

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2d475649f83d