842723 - Remove incorrect include of jsscriptinlines.h from CompileInfo.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Niko Matsakis [:nmatsakis]]

ion/CompileInfo.h includes jsscriptinlines.h, which it should not do, since inline files should be included from .cpp files to avoid cycles.

Comment 1

[Niko Matsakis [:nmatsakis]]

Attachment: Remove erroneous #include

Comment 2

[Niko Matsakis [:nmatsakis]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69a9bb6f645a

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I'm not sure I believe you...

http://mxr.mozilla.org/mozilla-central/search?string=inlines.h&find=js%2Fsrc%2F.*\.h&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

Comment 4

[Niko Matsakis [:nmatsakis]]

well, I suppose it's ok to include one inline header file from another.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/69a9bb6f645a

Comment 6

[Niko Matsakis [:nmatsakis]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f246412bcadb

Comment 7

[Daniel Holbert [:dholbert]]

In the future, probably good to look at HG blame when removing a line of code, and marking as "Depends-on" the bug in question, in case there was a reason that code was there.

This bug effectively was a backout of bug 840339, and it should have resulted in that bug being reopened. (Sine that didn't happen, I ended up wasting time filing a dupe & doing some repeated work on the re-introduced bug. :-/  )