842763 - [traceback] KeyError: u'Product' (/sl/kb/kako-se-uporablja-povecava)

Status: RESOLVED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

KeyError: u'Product'

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)
  File "django/views/decorators/http.py", line 41, in inner
    return func(request, *args, **kwargs)
  File "mobility/decorators.py", line 23, in wrapper
    return f(request, *args, **kw)
  File "wiki/views.py", line 138, in document
    return jingo.render(request, template, data)
  File "jingo/__init__.py", line 75, in render
    rendered = render_to_string(request, template, context)
  File "jingo/__init__.py", line 93, in render_to_string
    return template.render(get_context())
  File "jingo/__init__.py", line 189, in render
    return super(Template, self).render(context_dict)
  File "jinja2/environment.py", line 891, in render
    return self.environment.handle_exception(exc_info, True)
  File "/data/www/support.mozilla.org/kitsune/apps/wiki/templates/wiki/document.html", line 26, in top-level template code
    {% set meta = meta + [('description', document.current_revision.summary)] %}
  File "/data/www/support.mozilla.org/kitsune/apps/wiki/templates/wiki/base.html", line 7, in top-level template code
    {% set styles = ('wiki',) %}
  File "/data/www/support.mozilla.org/kitsune/templates/base.html", line 14, in top-level template code
    <title>{% block title %}{% if title %}{{ title }} | {% endif %}{{ _('Mozilla Support', 'site_title') }}{% endblock %}</title>
  File "/data/www/support.mozilla.org/kitsune/apps/wiki/templates/wiki/document.html", line 12, in block "title"
    {% block title %}{{ document.title }} | {% if not products or products|count > 1 %}{{ _('Mozilla Support', 'site_title') }}{% else %}{{ _('{product} Help')|f(product=_(product.title, 'DB: products.Product.title')) }}{% endif %}{% endblock %}
  File "jingo/helpers.py", line 26, in f
    return string.format(*args, **kwargs)


I just pushed to production and we immediate got like 20k of these errors.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Er, not 20k, but 12k.

Mike tracked it down to this:

#: apps/products/templates/products/documents.html:10 apps/products/templates/products/product.html:9 apps/products/templates/products/mobile/documents.html:8
#: apps/products/templates/products/mobile/product.html:8 apps/wiki/templates/wiki/document.html:12
msgid "{product} Help"
msgstr "{Product} Pomoč"


That's in the sl locale. I fixed it and committed to svn and pushed again.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

I haven't seen another one in 8 minutes. Marking this FIXED.

Comment 3

[Milos Dinic [:Milos]]

Adding Vito, as he's our Slovenian l10n god.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Vito: I saw a bunch of cases where text in between { } was uppercased in the sl strings. I fixed one under this bug and a bunch under bug #842774.

Comment 5

[Vito Smolej]

Red ears alert ... It was not me, it was Google Translate V2;\. 

I'll keep my eyes pealed for the rest of the material. Sl has fallen back a mile or two last few months, so I had some catching up to do.

Thanks, guys!

smo

Comment 6

[Will Kahn-Greene [:willkg] ET needinfo? me]

This should have been a P1. Marking it as such.