84283 - can't get mail: Exception : In mail commands

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[R.K.Aa.]

Linux CVS Pulled around 21:00
gcc 2.96-81

When i click "get mail" i only see "Exception : In mail commands" in console.
Mail isn't fetched, no throbber spins. News are OK.

Tested using alternate 3-pane and POP accounts.

Comment 1

[Nikos Platis]

Same behavior on 2001-06-05-20-trunk/Win98.

Comment 2

[Nikos Platis]

...but 2001-06-05-04-trunk works fine.

Comment 3

[R.K.Aa.]

Smoketest blocker since it don't work on windows either.

Perhaps related:
-The first two times i started mailnews, the window came up
empty - just window-frame/titlebar. No error msg. The third attempt started
mailnews seemingly OK.
-Sending mail works. I just can't get new mail msg's.
-Bug also affects default pane setup.

Comment 4

[R.K.Aa.]

CC dougt. This could be netwerk.

Comment 5

[Tracy Walker [:tracy]]

this is affecting windows branch build 2001-06-06-06-0.9.1

note: created a new profile with the same account that I am trying to get the 
mail from on a 4.77 machine and was able get mail messages just fine.

Comment 6

[David :Bienvenu]

cc'ing mscott and Navin

Comment 7

[(not reading, please use [e-mail] instead)]

investigating now.

Comment 8

[R.K.Aa.]

New profile on linux (not imported): same bug.
Btw..with the clean profile I was not prompted for password when i clicked "Get
Msg".

Comment 9

[esther]

Not a server problem, can get mail with 6-4 build on same system at about the
same time.  Big regression.

Comment 10

[(not reading, please use [e-mail] instead)]

bienvenu is deep in the debugger.  from what he's aimed me, it looks like 
dougt's changes may be the cause.

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 12

[(not reading, please use [e-mail] instead)]

bienvenu has another, simpler fix.  he's testing it now.

-  rv = NS_CheckPortSafety(port, "pop3");
+  rv = NS_CheckPortSafety(port, "pop");

update coming soon...

Comment 13

[David :Bienvenu]

Attachment: proposed patch

Comment 14

[(not reading, please use [e-mail] instead)]

more about dougt's changes:

will they prevent someone from using pop or news to run on any nonstandard 
ports?  looking at his diffs, it doesn't look like it.

> if (port == NEWS_PORT || port == 995 || port == 532) // port 995 is NNTP/SSL, 
532 is netnews

563 is the standard NNTP over SSL, not 995.

Comment 15

[(not reading, please use [e-mail] instead)]

> if (port == POP3_PORT || port == 593)  // 593 is POP3/SSL

the default POP over SSL port is 995

again, it looks like pop or nntp over non-standard ports will not work.

Comment 16

[Scott MacGregor]

doug said for mail protocols we are always accepting connections on all ports. I
talked about this on the phone with him yeterday 'cause I was worried that we
wouldn't be allowing connections on some of the non-standard ports we frequently
encounter. The mail protocols are supposed to return PR_TRUE whenever we ask a
mail protocol handler if it allows connections on a particular port. Is this not
the case for news and pop? I was under the impression that it was true for all
mail protocols.

Comment 17

[Doug Turner (:dougt)]

My fault; Sorry.

I thought we were talking about oonly smtp and IMAP for the potential commercial
bustage.

Patch:

Index: local/src/nsPop3Service.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/local/src/nsPop3Service.cpp,v
retrieving revision 1.68.32.1
diff -u -r1.68.32.1 nsPop3Service.cpp
--- nsPop3Service.cpp 2001/06/05 23:44:11 1.68.32.1
+++ nsPop3Service.cpp 2001/06/06 17:03:12
@@ -314,10 +314,7 @@

NS_IMETHODIMP nsPop3Service::AllowPort(PRInt32 port, const char *scheme, PRBool
*_retval)
{
- if (port == POP3_PORT || port == 593) // 593 is POP3/SSL
- *_retval = PR_TRUE;
- else
- *_retval = PR_FALSE;
+ *_retval = PR_TRUE; // allow pop on any port
return NS_OK;
}

Index: news/src/nsNntpService.cpp
===================================================================
RCS file: /cvsroot/mozilla/mailnews/news/src/nsNntpService.cpp,v
retrieving revision 1.189.12.1
diff -u -r1.189.12.1 nsNntpService.cpp
--- nsNntpService.cpp 2001/06/05 23:44:14 1.189.12.1
+++ nsNntpService.cpp 2001/06/06 17:03:13
@@ -1202,10 +1202,7 @@

NS_IMETHODIMP nsNntpService::AllowPort(PRInt32 port, const char *scheme, PRBool
*_retval)
{
- if (port == NEWS_PORT || port == 995 || port == 532) // port 995 is NNTP/SSL,
532 is netnews
- *_retval = PR_TRUE;
- else
- *_retval = PR_FALSE;
+ *_retval = PR_TRUE; // allow news on any port
return NS_OK;
}


Seth, this is clearly my bug. Reassigning. I will check it into the branch and
to trunk once r/sr/a'ed

Comment 18

[Doug Turner (:dougt)]

.

Comment 19

[(not reading, please use [e-mail] instead)]

this bug will require bienvenu's fix (see the last attachment).

r/sr=sspitzer on that.  (mscott, dougt, can you review also)?

dougt, I'll get you a new bug for the NNTP, POP, LDAP port problems.

Comment 20

[David :Bienvenu]

OK, please make sure you check in my patch too, because otherwise we'll never
get to the pop3 protocol to ask it about the ports it can handle!

Comment 21

[Doug Turner (:dougt)]

Attachment: Proposed Patch v.2

Comment 22

[Doug Turner (:dougt)]

done.  can I get a r/sr?

Comment 23

[R.K.Aa.]

Is there a related HTTP hickup? When opening new webpages with middle
mouse click (in new window) i now and then see only framwork - GUI and
content never paints. Never saw that before today, but same thing happened when
i tried to start mailnews earlyer. (see comment above)

Comment 24

[(not reading, please use [e-mail] instead)]

r/sr=sspitzer

Comment 25

[Doug Turner (:dougt)]

RKA  - I would be surprised.  File a new bug.

seth - thanks - you da man.

thanks everyone for quickly jumping on this.  I will seek approval now.

Comment 26

[Scott MacGregor]

r=mscott

Comment 27

[Christopher Blizzard (:blizzard)]

a=blizzard on behalf of drivers for the trunk and the branch

Comment 28

[Doug Turner (:dougt)]

set is going to open up some bugs regarding what ports mail news should be
accepting.  These bugs will be for 0.9.2.

The fix has been checked in.

Comment 29

[Bradley Baetz (:bbaetz)]

Is there a particular reason that an error dialog wasn't shown to the user?

Comment 30

[Tracy Walker [:tracy]]

verified in linux commercial build 2001-060-06-11-trunk

will wait for mac and windows to actually mark verified.

Comment 31

[lchiang]

need to verify on the branch as well.  I'll ask the mail qa group.

Comment 32

[laurel]

OK with commercial branch 2001-06-06-12-0.9.1 on win98

Comment 33

[Karen Huang]

By uisng WinNT 2001-06-06-14-0.9.1 build POP account.
I can read & send mails from the POP account.

Comment 34

[[e-mail] (gone - use [e-mail] instead)]

This works on my linux 2001-06-06-13-0.9.1 build, using my POP3 account. 
Anybody have the other plats handy and can verify?

Comment 35

[laurel]

OK using commercial branch build 2001-06-06-12-.0.9.1 mac OS 9.0

Comment 36

[Karen Huang]

I am wondering to know whether we have POP/SSL for internal testing or not?
Should we verify on POP/SSL as well? 

Comment 37

[[e-mail] (gone - use [e-mail] instead)]

This also works on Mac OS 9.1 with build 2001-06-06-12-0.9.1

Comment 38

[esther]

Using branch builds on all 3 platforms get mail for pop account works. Verified 
for branch will check trunk now.

Comment 39

[esther]

verified on trunk builds 2001-06-13  Verified for both branch and trunk