Closed Bug 84285 Opened 25 years ago Closed 25 years ago

enter_bug.cgi : asking user to pick from a list of 0 products

Categories

(Bugzilla :: Bugzilla-General, defect)

x86
Other
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 2.14

People

(Reporter: paul.thomas, Assigned: tara)

Details

Attachments

(3 files)

Problem. I setup Bugzilla 2.12. I turned on both usebuggroups and usebuggroupsentry. I created a product "ProdX". I created 10 users. I assigned 2 of these users to be members of the "ProdX" group. I clicked to enter a new bug. I logged in as one of the users who is NOT in the "ProdX" group. I got the Enter Bug screen saying "First, you must pick a product on which to enter a bug" but there were no products listed. So I couldn't get any further. Solution. When the user is not permitted to enter bugs against any products, return a sensible message rather than asking them to pick from a list with 0 elements.
Target Milestone: --- → Bugzilla 2.16
I made some changes to the enter_bug.cgi to fix this bug I reported earlier. I've tested the fix and it works here on my system. Hopefully some of you guys will review it and it will get in to the next version. regards Paul
Can you post this again as a diff -u? Because files are constantly changing, a diff makes it easier to see what's changed as well as slowing the process of bit-rotting.
bumping to 2.14. Seeing what this patch does, this actually fits right in with all the permission checking stuff we've just been fixing up.
Keywords: patch, review
Target Milestone: Bugzilla 2.16 → Bugzilla 2.14
A couple of comments: * It appears that you don't need both $tableContents and $tempStr * And, of course, my favorite comment, whitespace :) The current standard in bugzilla is for every block to have the open brace on the same line as statement that starts it. For example: if ($whatever) { # True stuff here } else { # False } Other than that, this looks good.
Attached patch an updated patch — — Splinter Review
I've resubmitted the patch with Jakes suggestions in it.
On line 107 you have '$tableContents =' and it should be '$tableContents .='. I made that correction and this is now checked in. r=jake
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Moving to Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: Bugzilla 2.12 → unspecified
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: