Closed Bug 842864 Opened 7 years ago Closed 7 years ago

Tracking bug for 13-may-2013 migration work

Categories

(Release Engineering :: General, defect, P3)

x86
All
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: joduinn, Assigned: rail)

References

Details

Attachments

(3 files, 4 obsolete files)

Assignee: nobody → rail
Priority: -- → P3
# MERGE DAY - pulseaudio-libs-devel package rides the trains (bug 662417)
# MERGE DAY - Remove branches as FF21 reaches them
Depends on: 662417
# MERGE DAY NOTE: remove v21 based branches from the list below                                                                                 NON_UBUNTU_BRANCHES = ("mozilla-beta", "mozilla-release", "mozilla-esr17",
                       "mozilla-b2g18", "mozilla-b2g18_v1_0_0", "mozilla-b2g18_v1_0_1")
Depends on: 835660
Duplicate of this bug: 856805
Merge is scheduled for the 13th, release on the 14th, per
  https://wiki.mozilla.org/RapidRelease/Calendar
Summary: Tracking bug for 14-may-2013 migration work → Tracking bug for 13-may-2013 migration work
Depends on: 854460
Attached patch beta to release (obsolete) — Splinter Review
Attached patch aurora to beta (obsolete) — Splinter Review
Attached patch central to aurora (obsolete) — Splinter Review
All patches are incremental and will be re-checked next week.
Blocks: 854372
Blocks: 868979
Attached patch beta to releaseSplinter Review
I think this can be landed anytime.
Attachment #744836 - Attachment is obsolete: true
Attachment #745856 - Flags: review?(bhearsum)
Comment on attachment 745856 [details] [diff] [review]
beta to release

Review of attachment 745856 [details] [diff] [review]:
-----------------------------------------------------------------

I thought these things were supposed to be taken care of in the individual bugs, by their owners? I don't have context on most of these, so my review isn't very useful I think...

::: mozilla-tests/config.py
@@ +1228,5 @@
>      loadDefaultValues(BRANCHES, projectBranch, branchConfig)
>      loadCustomTalosSuites(BRANCHES, SUITES, projectBranch, branchConfig)
>  
>  # MERGE DAY NOTE: remove v21 based branches from the list below
> +NON_UBUNTU_BRANCHES = ("mozilla-esr17", "mozilla-b2g18", "mozilla-b2g18_v1_0_1")

Does this change cover uplifting mozharness unit tests (bug 843408)?
Attachment #745856 - Flags: review?(bhearsum)
(In reply to Ben Hearsum [:bhearsum] from comment #9)
> Comment on attachment 745856 [details] [diff] [review]
> beta to release
> 
> Review of attachment 745856 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I thought these things were supposed to be taken care of in the individual
> bugs, by their owners? I don't have context on most of these, so my review
> isn't very useful I think...

I prepared the patch myself by expecting the dep bugs and skimming the code. It looks safer to me, easier to catch missed uplifts like https://bugzilla.mozilla.org/show_bug.cgi?id=842863#c6.

> ::: mozilla-tests/config.py
> @@ +1228,5 @@
> >      loadDefaultValues(BRANCHES, projectBranch, branchConfig)
> >      loadCustomTalosSuites(BRANCHES, SUITES, projectBranch, branchConfig)
> >  
> >  # MERGE DAY NOTE: remove v21 based branches from the list below
> > +NON_UBUNTU_BRANCHES = ("mozilla-esr17", "mozilla-b2g18", "mozilla-b2g18_v1_0_1")
> 
> Does this change cover uplifting mozharness unit tests (bug 843408)?

No. That will be for aurora->beta uplift (for 22.0b1).
Comment on attachment 745856 [details] [diff] [review]
beta to release

Review of attachment 745856 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/config.py
@@ +1211,5 @@
>  
>  # Let's load jetpack for the following branches:
>  # MERGE DAY once FF21 merges into a branch remove it from this list
>  for branch in BRANCHES.keys():
> +    if branch not in ('mozilla-esr17', 'mozilla-b2g18', 'mozilla-b2g18_v1_0_1'):

Armen, any stoppers for this uplift?

::: mozilla/config.py
@@ +1964,5 @@
>                  del BRANCHES[b]['platforms'][p]
>  
>  # MERGE DAY - pulseaudio-libs-devel package rides the trains (bug 662417)
>  # MERGE DAY - Remove branches as FF21 reaches them
> +for b in ['mozilla-esr17', 'mozilla-b2g18', 'mozilla-b2g18_v1_0_1']:

jhopkins, any stoppers here?
Attachment #745856 - Flags: review?(jhopkins)
Attachment #745856 - Flags: review?(armenzg)
Comment on attachment 745856 [details] [diff] [review]
beta to release

Review of attachment 745856 [details] [diff] [review]:
-----------------------------------------------------------------

All good from my side.
Attachment #745856 - Flags: review?(armenzg) → review+
Comment on attachment 745856 [details] [diff] [review]
beta to release

Looks good.  As Rail mentioned in IRC, Thunderbird tracks FF17 so thunderbird_config.py is not included in this patch.
Attachment #745856 - Flags: review?(jhopkins) → review+
in production
Attached patch aurora to betaSplinter Review
Attachment #744838 - Attachment is obsolete: true
Comment on attachment 747976 [details] [diff] [review]
aurora to beta

Review of attachment 747976 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/config.py
@@ -1169,5 @@
>  BRANCHES['mozilla-beta']['platforms']['win32']['talos_slave_platforms'] = ['xp', 'win7', 'win8']
>  # End MERGE DAY remove the above when Firefox 23 merges in
> -# MERGE DAY remove the below when Firefox 22 merges in
> -BRANCHES['mozilla-beta']['platforms']['linux']['fedora']['opt_unittest_suites'] = BUILDBOT_UNITTEST_SUITES['opt_with_ipc'][:]
> -BRANCHES['mozilla-beta']['platforms']['linux']['fedora']['debug_unittest_suites'] = BUILDBOT_UNITTEST_SUITES['debug'][:]

aki, per http://hg.mozilla.org/build/buildbot-configs/annotate/0300777067f5/mozilla-tests/config.py#l1171 you added this code. Are we safe to uplift the changes in this hunk?

::: mozilla-tests/mobile_config.py
@@ +577,5 @@
>  # MERGE DAY, drop trees from branch list as Firefox 22 rides forward.
>  for branch in BRANCHES.keys():
>      # Loop removes it from any branch that gets beyond here
> +    if branch not in ('mozilla-release', 'mozilla-esr17', 'mozilla-b2g18',
> +                      'mozilla-b2g18_v1_0_1'):

Callek, are we safe to uplift this hunk?

::: mozilla/config.py
@@ +1996,1 @@
>      BRANCHES[b]["run_make_alive_tests"] = False

Armen, are we safe to uplift this hunk?
Attachment #747976 - Flags: review?(bugspam.Callek)
Attachment #747976 - Flags: review?(armenzg)
Attachment #747976 - Flags: review?(aki)
Attached patch central to aurora (obsolete) — Splinter Review
Attachment #744840 - Attachment is obsolete: true
Comment on attachment 747982 [details] [diff] [review]
central to aurora

Review of attachment 747982 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/config.py
@@ -1174,5 @@
>  BRANCHES['mozilla-aurora']['pgo_strategy'] = 'per-checkin'
> -# MERGE DAY remove the below when Firefox 23 merges in
> -del BRANCHES['mozilla-aurora']['platforms']['win32']['win7-ix']
> -BRANCHES['mozilla-aurora']['platforms']['win32']['talos_slave_platforms'] = ['xp', 'win7', 'win8']
> -# End MERGE DAY remove the above when Firefox 23 merges in

Armen, are we safe to uplift this?

@@ -1355,5 @@
>  
>  # MERGE DAY: remove branches when Firefox 23 merges in
> -NON_UBUNTU_TALOS_BRANCHES = ("mozilla-aurora", "mozilla-beta",
> -                             "mozilla-release", "mozilla-esr17",
> -                             "mozilla-b2g18", "mozilla-b2g18_v1_0_1")

r+ from me :)

::: mozilla-tests/mobile_config.py
@@ +596,5 @@
>  # MERGE DAY, drop trees from branch list as Firefox 23 rides forward.
>  for branch in BRANCHES:
>      # Loop removes it from any branch that gets beyond here
> +    if branch not in ('mozilla-beta', 'mozilla-release', 'mozilla-esr17',
> +                      'mozilla-b2g18', 'mozilla-b2g18_v1_0_1'):

Callek, how about this uplift?
Attachment #747982 - Flags: review?(bugspam.Callek)
Attachment #747982 - Flags: review?(armenzg)
Attachment #747976 - Flags: review?(bugspam.Callek) → review+
Attachment #747982 - Flags: review?(bugspam.Callek) → review+
Attachment #747976 - Flags: review?(aki) → review+
Attachment #747976 - Flags: review?(armenzg) → review+
Comment on attachment 747982 [details] [diff] [review]
central to aurora

Review of attachment 747982 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/config.py
@@ -1174,5 @@
>  BRANCHES['mozilla-aurora']['pgo_strategy'] = 'per-checkin'
> -# MERGE DAY remove the below when Firefox 23 merges in
> -del BRANCHES['mozilla-aurora']['platforms']['win32']['win7-ix']
> -BRANCHES['mozilla-aurora']['platforms']['win32']['talos_slave_platforms'] = ['xp', 'win7', 'win8']
> -# End MERGE DAY remove the above when Firefox 23 merges in

Can I take care of this one? I hope to have more win7 machines next week to handle more load than just Cedar but I'm not 100% if they will be ready by Monday.
Attachment #747982 - Flags: review?(armenzg) → review+
(In reply to Armen Zambrano G. [:armenzg] (Release Enginerring) from comment #20)
> Comment on attachment 747982 [details] [diff] [review]
> central to aurora
> 
> Review of attachment 747982 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mozilla-tests/config.py
> @@ -1174,5 @@
> >  BRANCHES['mozilla-aurora']['pgo_strategy'] = 'per-checkin'
> > -# MERGE DAY remove the below when Firefox 23 merges in
> > -del BRANCHES['mozilla-aurora']['platforms']['win32']['win7-ix']
> > -BRANCHES['mozilla-aurora']['platforms']['win32']['talos_slave_platforms'] = ['xp', 'win7', 'win8']
> > -# End MERGE DAY remove the above when Firefox 23 merges in
> 
> Can I take care of this one? I hope to have more win7 machines next week to
> handle more load than just Cedar but I'm not 100% if they will be ready by
> Monday.

Sure. I removed that hunk. Carry over r+.
Attachment #747982 - Attachment is obsolete: true
Attachment #748050 - Flags: review+
In production
Depends on: 871608
No longer blocks: 854372
Depends on: 873581
All done here.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.