842909 - "ASSERTION: expected a TextNodeCorrespondenceProperty on nsTextFrame used for SVG text"

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

Attachment: testcase

With:
  user_pref("svg.text.css-frames.enabled", true);

###!!! ASSERTION: expected a TextNodeCorrespondenceProperty on nsTextFrame used for SVG text: 'Not Reached', file layout/svg/nsSVGTextFrame2.cpp, line 1226

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

UpdateGlyphPositioning ensures that everything is set up correctly. It's normally called whenever we reflow/redraw but in the case of text in <defs>, we never do directly so we have to ensure that all dom functions call it.

Check out http://mxr.mozilla.org/mozilla-central/source/layout/svg/nsSVGTextFrame.cpp#91 for the methods that get called if svg.text.css-frames.enabled is false and the missing function call becomes more obvious in the svg.text.css-frames.enabled case.

Comment 2

[Robert Longson [:longsonr]]

Attachment: better with the crashtest

Comment 3

[Robert Longson [:longsonr]]

Attachment: third time lucky, right patch this time I hope.

Comment 4

[Robert Longson [:longsonr]]

https://tbpl.mozilla.org/?tree=Try&rev=85492f285119

Comment 5

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d4fb3ae51be

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9d4fb3ae51be