842952 - Implement the LightLevelEvent Interface

Status: NEW

(Core :: DOM: Device Interfaces, defect, P3)

Description

[Jeremie Patonnier :Jeremie]

As we have the DeviceLightEvent interface, it would be nice to also have the LightLevelEvent interface.

Comment 1

[Doug Turner (:dougt)]

jeremie, is this something you want to implement?

Comment 2

[Jeremie Patonnier :Jeremie]

(In reply to Doug Turner (:dougt) from comment #1)
> jeremie, is this something you want to implement?

I would like to. Unfortunately, I have no time until end of March and I have absolutely no C++ skills at all which make things a little hard (even if it does not seam to difficult regarding the work already done on DeviceLightEvent)

So if no one take it until spring, I'll try to fix it. In the meantime, feel free to take it or to give it to someone else.

Comment 3

[Jorge Luis Mendez [:jlmendezbonini]]

Thanks for submitting the bug Jeremie! You beat me to it by a couple of days :)

Anyhow, I'm taking this bug if nobody has other plans.

Comment 4

[Jorge Luis Mendez [:jlmendezbonini]]

I just noticed that the interface on the latest editor's draft uses an |enum| instead of a |string|[2].  Should we implement it as an enum?.  This is the only thing that I'm missing to submit a patch for review.

[1]https://dvcs.w3.org/hg/dap/raw-file/tip/light/Overview.html#lightlevelevent-interface
[2]http://www.w3.org/TR/ambient-light/#lightlevelevent-interface

Comment 5

[Jorge Luis Mendez [:jlmendezbonini]]

Attachment: WIP: Implement the LightLevelEvent Interface

The patch lacks the proper LightLevelEvent interface definition and currently implements it almost exactly like DeviceLight for testing.

Comment 6

[Doug Turner (:dougt)]

i think using the enum is the right thing.

Comment 7

[Anne (:annevk)]

I don't think we need to implement this, unless I'm missing something: http://lists.w3.org/Archives/Public/public-device-apis/2013Apr/0019.html

Comment 8

[Anne (:annevk)]

Jorge, could you update the patch to instead implement this attribute on top of DeviceLightEvent instead? That's the way we want to go forward here.

See http://lists.w3.org/Archives/Public/public-device-apis/2013Apr/0048.html

Comment 9

[Jorge Luis Mendez [:jlmendezbonini]]

Hi Anne.  Sure, I'll update the patch. Sorry for the delay, I've had some very busy weeks.

Comment 10

[Jorge Luis Mendez [:jlmendezbonini]]

It's been a while.  New job and, sadly, I won't be able to work on this anytime soon.