Implement the LightLevelEvent Interface




DOM: Device Interfaces
5 years ago
4 years ago


(Reporter: Jeremie, Unassigned)



Firefox Tracking Flags

(Not tracked)




(1 attachment)



5 years ago
As we have the DeviceLightEvent interface, it would be nice to also have the LightLevelEvent interface.

Comment 1

5 years ago
jeremie, is this something you want to implement?

Comment 2

5 years ago
(In reply to Doug Turner (:dougt) from comment #1)
> jeremie, is this something you want to implement?

I would like to. Unfortunately, I have no time until end of March and I have absolutely no C++ skills at all which make things a little hard (even if it does not seam to difficult regarding the work already done on DeviceLightEvent)

So if no one take it until spring, I'll try to fix it. In the meantime, feel free to take it or to give it to someone else.
Thanks for submitting the bug Jeremie! You beat me to it by a couple of days :)

Anyhow, I'm taking this bug if nobody has other plans.
I just noticed that the interface on the latest editor's draft uses an |enum| instead of a |string|[2].  Should we implement it as an enum?.  This is the only thing that I'm missing to submit a patch for review.

Created attachment 727024 [details] [diff] [review]
WIP: Implement the LightLevelEvent Interface

The patch lacks the proper LightLevelEvent interface definition and currently implements it almost exactly like DeviceLight for testing.

Comment 6

4 years ago
i think using the enum is the right thing.

Comment 7

4 years ago
I don't think we need to implement this, unless I'm missing something:

Comment 8

4 years ago
Jorge, could you update the patch to instead implement this attribute on top of DeviceLightEvent instead? That's the way we want to go forward here.

Hi Anne.  Sure, I'll update the patch. Sorry for the delay, I've had some very busy weeks.
It's been a while.  New job and, sadly, I won't be able to work on this anytime soon.
You need to log in before you can comment on or make changes to this bug.