842959 - Add-on menu items are not showing up in browser menu when viewing Chrome:// & Java pages

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect)

Description

[crazyskeggy]

Attachment: Shows I have ABP and Phony, but no menu items.

Repro steps: 
1. Install add-ons like ABP to Firefox Beta.
2. Reboot tablet
3. Open the menu in the top-right.

Expected result:
APP's "disable on....com" shows in the menu.

Actual result:
Only 6 options show.

Extra info:
This is not a due of the "destroy all activities" bug as I do not have that dev option enabled.
Dev settings on:
Protect SD Card
USB Debug (so that I can copy files onto the device)
Show touches
Window Animation 2x
Transition Animation 1.5x
Strict mode


I am running an ASUS Transformer TF300T with Android 4.1.1.

Comment 1

[Aaron Train [:aaronmt]]

Sriram mind taking a look at this regarding the menu and externally added items from add-ons not persisting?

Comment 2

[Sriram Ramasubramanian [:sriram]]

Are the addons enabled in "Menu > Tools > Addons" in this case. There is a possibility that they are disabled due to OOM.

Comment 3

[crazyskeggy]

Attachment: ABP is enabled

Unfortunately, this isn't the case, as you can see in the attachment. ABP is enabled (the menu item is, however, still missing)

Comment 4

[Aaron Train [:aaronmt]]

I see this on Nightly too

Install Adblock Plus, open the menu, dont see the Adblock Plus menu item anymore

CC'ing Wes/Margaret

Comment 5

[Aaron Train [:aaronmt]]

Looks like this happens only when the browser has an active Chrome:// URI visible; such as the case with the default Adblock Plus settings page.

We should probably show the menu item regardless

Comment 6

[Aaron Train [:aaronmt]]

There may be other cases, but I can clearly see this when my active tab is on the Adblock Plus installed page

Comment 7

[Aaron Train [:aaronmt]]

Same deal with our java pages; e.g, about:addons

Comment 8

[Sriram Ramasubramanian [:sriram]]

I think its done by ABP, and not us. We don't block any addons in about:// pages, do we?

Comment 9

[crazyskeggy]

Other add-ons such as Phony and Fullll Screen do this too, though - it can't be just ABP's fault.

Comment 10

[:Margaret Leibovic]

(In reply to Aaron Train [:aaronmt] from comment #7)
> Same deal with our java pages; e.g, about:addons

Our only Java page is about:home (about:addons is an html page). And even about:home has a real html page behind it to keep track of things like navigation state.

To try to reproduce this bug, I installed the simple view source add-on [1], and I'm still seeing it show up on about: pages (including about:home). I suspect this is an add-on specific thing, since I also have ABP installed, and its menuitem does only appear on some pages.

[1] https://addons.mozilla.org/en-us/android/addon/view-source-mobile/

Comment 11

[crazyskeggy]

Quicker way to repro: close Firefox, open recent apps, swipe so that the app gets closed (either sideways or vertically, depending on whether you are on ICS/JB4.1 or JB4.2 with new launcher enabled, then reopen Firefox from the Launcher (homescreen).

Comment 12

[Aaron Train [:aaronmt]]

This is still kind of dumb; you install Addblock Plus and you want to enable it after installing but you don't see the menu item because they supply a packaged chrome:// URL that opens after installing. You think it's broken.

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

Is this explicit behavior from ABP

Comment 14

[Wladimir Palant]

(In reply to Brad Lassey [:blassey] from comment #13)
> Is this explicit behavior from ABP

Yes, it is. This is an action, not a status indicator. And that action only makes sense on actual web pages, elsewhere it would merely add noise to the menu.

This is a clear WONTFIX to me - at least until there are actual status indicators in Fennec (e.g. on tablets since they have large enough screens)

Comment 15

[Wladimir Palant]

Oh, this is filed as a Fennec bug - it's WORKSFORME then, sorry about the spam.