Closed Bug 842992 Opened 10 years ago Closed 10 years ago

l10n changesets error messages in release sanity suck

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

Details

Attachments

(1 file)

When we check the revisions of l10n repos in release sanity we do a simple http get to URLs such as: https://hg.mozilla.org/releases/l10n/mozilla-beta/zh-CN/file/1e65623aaf2e

When we get ANY failure from them, we throw a message like:
ERROR : cannot find l10n locale zh-CN in repo https://hg.mozilla.org/releases/l10n/mozilla-beta/zh-CN/file/1e65623aaf2e

There's a couple of  problems with this:
1) The error message is ambiguous (it should say something like "couldn't find revision X for locale Y at URL Z)
2) Not all errors should be treated equally. 5xx errors should throw a different (after retrying, if possible).
Attached patch make it betterSplinter Review
Bonus: checks locales in alphabetical order.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #717297 - Flags: review?(rail)
Attachment #717297 - Flags: review?(rail) → review+
Attachment #717297 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.