843059 - Running reftests via |TEST_PATH=x make -C $(OBJDIR) reftest| is broken (Error: Path $OBJDIR/_tests/dist/NightlyDebug.app/Contents/MacOS/firefox-bin doesn't exist.)

Status: RESOLVED DUPLICATE of bug 841713

(Testing :: Reftest, defect)

Description

[Jonathan Watt [:jwatt]]

With latest mozilla-inbound, running reftests via

TEST_PATH=x make -C $(OBJDIR) reftest

as documented in:

https://developer.mozilla.org/en-US/docs/Creating_reftest-based_unit_tests

seems to have been broken by something. I now get the error message:

Error: Path $OBJDIR/_tests/dist/NightlyDebug.app/Contents/MacOS/firefox-bin doesn't exist.

Comment 1

[Jonathan Watt [:jwatt]]

Seems mach is also broken. Same error with:

./mach reftest layout/reftests/svg/smil/

Comment 2

[Jonathan Watt [:jwatt]]

Is there a workaround for the moment in order to be able to run reftests?

Comment 3

[Gregory Szorc [:gps]]

I removed objdir.pth from my local virtualenv and |make reftest| works now.

I'm baffled as to why. I guess we should back out bug 841713. I'll do that now.

Comment 4

[Gregory Szorc [:gps]]

Will figure it out in bug 841713.

Comment 5

[Jonathan Watt [:jwatt]]

[To be clear, the patch for bug 841713 was backed out.]

Comment 6

[(not currently active) Ted Mielczarek]

The root cause here is that automation.py contains an interpolated path which is relative to the objdir directory where automation.py winds up:
http://mxr.mozilla.org/mozilla-central/source/build/automation.py.in#51
http://mxr.mozilla.org/mozilla-central/source/build/automation-build.mk#14

I...don't remember why we do things this way. Presumably we could just preprocess absolute paths into that file and use the single copy in build/.