843094 - Remove the Property Panel

Status: RESOLVED FIXED

(DevTools :: Console, defect, P3)

Description

[Mihai Sucan [:msucan]]

Once bug 808370 and bug 808369 are both fixed we need to remove all of the Property Panel code from the Web Console and PropertyPanel.jsm.

Comment 1

[Mihai Sucan [:msucan]]

Also note that WebConsoleUtils.jsm needs to be cleaned-up here.

Comment 2

[Brandon Benvie [:benvie]]

Attachment: WIP1

First stab at this.

Comment 3

[Brandon Benvie [:benvie]]

https://tbpl.mozilla.org/?tree=Try&rev=153e8f30022d

Comment 4

[Mihai Sucan [:msucan]]

Yay, thank you! When this patch is ready please ask for review.

Comment 5

[Brandon Benvie [:benvie]]

Attachment: WIP2

I think those failures were something not related to my patch, but we'll see. Let's try again. https://tbpl.mozilla.org/?tree=Try&rev=70434821b1c3

Comment 6

[Brandon Benvie [:benvie]]

Attachment: WIP3

I think I fixed it. https://tbpl.mozilla.org/?tree=Try&rev=62638fb84602

Comment 7

[Mihai Sucan [:msucan]]

Comment on attachment 743799 [details] [diff] [review]
WIP3

This is a much welcome clean up. Giving it r+ but I think it's not complete.

In WebConsoleUtils.jsm there are a bunch of methods you can now remove: getObjectGrip, formatResult, formatResultString, getResultType, getObjectClassName, isObjectInspectable, getFunctionName, getFunctionArguments, createValueGrip, inspectObject, inspectObjectProperty, propertiesSort, objectActorGripToString. I hope I didn't miss anything. Please remove these as well and do another try push, all systems, enable all tests - just to make sure there's no other code that uses these methods.

Thank you!

Comment 8

[Brandon Benvie [:benvie]]

Attachment: WIP4

Removed from WebConsuleUtils.jsm:

* getObjectGrip
* formatResult
* formatResultString
* getResultType
* objectActorGripToString
* getPropertyPanelValue
* getFunctionArguments

Not removed:

* getObjectClassName (used in VariablesView)
* isObjectInspectable (used in a test)
* getFunctionName (used in getObjectClassName)
* inspectObject (used in a test)
* inspectObjectProperty (used in inspectObject)

https://tbpl.mozilla.org/?tree=Try&rev=0a04c70fe735

Comment 9

[Mihai Sucan [:msucan]]

(In reply to Brandon Benvie [:bbenvie] from comment #8)
> Created attachment 744711 [details] [diff] [review]
> WIP4
> [...]
> Not removed:
> 
> * isObjectInspectable (used in a test)

Please remove the check that calls isObjectInspectable() - that was intended to check things which no longer apply to how the web console works. That test is browser_webconsole_bug_632347_iterators_generators.js.


> * inspectObject (used in a test)
> * inspectObjectProperty (used in inspectObject)

In browser_webconsole_bug_651501_document_body_autocomplete.js you can remove the call to inspectObject() and only check that, say, more than 14 properties are displayed. The purpose of the test is to check that document.body autocomplete works twice, it doesn't matter how many properties are displayed in the popup (as long as the number is greater than 0).

Thank you!

Comment 10

[Brandon Benvie [:benvie]]

Attachment: WIP5

* remove isObjectInspectable and update test that used it
* remove inspectObject and update test that used it
* remove inspectObjectProperty
* remove sandbox.inspect (front for inspectObject)

Comment 11

[Brandon Benvie [:benvie]]

https://tbpl.mozilla.org/?tree=Try&rev=1d7d9a9bcf7c

Comment 12

[Brandon Benvie [:benvie]]

Let's try that again. https://tbpl.mozilla.org/?tree=Try&rev=5a53b7b15433

Comment 13

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/4475f15789cc

Comment 14

[Joe Walker [:jwalker]]

https://hg.mozilla.org/mozilla-central/rev/4475f15789cc