843190 - Camera/mics can't be shared in getUserMedia if the permissions UI is disabled

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

This was missed in the patch for bug 811757

We'll want to uplift this patch to Aurora and Beta

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Allow cameras/mics to be shared if permissions UI is disabled

Comment 2

[Jason Smith [:jsmith]]

This reads off as a MWC demo risk.

Comment 3

[Timothy B. Terriberry (:derf)]

Comment on attachment 716076 [details] [diff] [review]
Allow cameras/mics to be shared if permissions UI is disabled

Review of attachment 716076 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9874a60b708f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9874a60b708f

Comment 7

[Jason Smith [:jsmith]]

Verified on Nightly. Needs an uplift to Aurora and Beta.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 716076 [details] [diff] [review]
Allow cameras/mics to be shared if permissions UI is disabled

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 811757 (missed the "permission-ui-disabled" case)

User impact if declined: People who flip the "permissions-ui-disabled" pref (media.navigator.permission.disabled) won't be able to share the camera or mic between tabs (or within a tab).  Note that for privacy reasons we would not suggest normal users ever flip that pref; it's mostly used for testing and demos like MWC.  This may mitigate against taking this patch on Beta or perhaps Aurora.

Testing completed (on m-c, etc.): on m-c, Verified
 
Risk to taking this patch (and alternatives if risky): Very low, simple patch.

String or UUID changes made by this patch: none.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/be805356580c
https://hg.mozilla.org/releases/mozilla-beta/rev/03f51c4f4465

Comment 10

[Mihaela Velimiroviciu (:mihaelav)]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20100101 Firefox/20.0
Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20100101 Firefox/20.0

Verified the fix on Firefox 20 beta 2.
Steps:
1. Set  media.navigator.permission.disabled to true
2. Open http://mozilla.github.com/webrtc-landing/gum_test.html in 2 tabs
3. Start video in 1st tab
4. Start video in 2nd tab
Result: video works in both tabs.

Comment 11

[Jason Smith [:jsmith]]

Technically that isn't totally how you needed to verify the bug - you needed to test cases with audio & USB+integrated devices. But I already went through this on Nightly, so no worries.

Comment 12

[Mihaela Velimiroviciu (:mihaelav)]

(In reply to Jason Smith [:jsmith] from comment #11)
> Technically that isn't totally how you needed to verify the bug - you needed
> to test cases with audio & USB+integrated devices. But I already went
> through this on Nightly, so no worries.

I forgot to mention that I used USB web camera (on Windows and Linux) and integrated iMac camera (on Mac OS) for the steps in comment #10. The share camera permission dialog did not appear and camera capture worked fine.
If that was not enough, could you please go through this on Firefox 20 beta 2 in order to properly verify on this branch, as well?
Thanks!

Comment 13

[Maire Reavy [:mreavy]]

Fixed in Fx20.  Clearing webrtc-uplift flag.