Compute whether to use XBL scopes exactly once

RESOLVED FIXED in Firefox 21

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla22
Points:
---

Firefox Tracking Flags

(firefox21 fixed, firefox22 fixed)

Details

Attachments

(4 attachments)

Assignee

Description

6 years ago
This will let us avoid doing work in certain cases, and reduces the refactoring required to define Components on the XBL scope.
Assignee

Comment 2

6 years ago
The only call-site for both of these is JSD->nsXPConnect::InitClasses, so this
is equivalent. All this will go away soon anyhow when JSD goes away.
Attachment #716152 - Flags: review?(bzbarsky)
Assignee

Comment 3

6 years ago
This stuff has all been simplified significantly with CPG, and this is no longer
necessary. We always have a global when we construct a scope, and it never
changes.
Attachment #716153 - Flags: review?(bzbarsky)
Assignee

Comment 6

6 years ago
I figured out a simpler way to do the Components stuff so this no longer blocks, but it's a good thing to do anyway.
No longer blocks: 790732
Comment on attachment 716152 [details] [diff] [review]
Part 1 - Move the nulling out of mPrototypeNoHelper from SetGlobal to RemoveWrappedNativeProtos. v1

r=me
Attachment #716152 - Flags: review?(bzbarsky) → review+
Comment on attachment 716153 [details] [diff] [review]
Part 2 - Remove SetGlobalObject. v1

It's called SetGlobal, not SetGlobalObject.

r=me with that, I guess.
Attachment #716153 - Flags: review?(bzbarsky) → review+
Comment on attachment 716155 [details] [diff] [review]
Part 3 - Alter the XBL scope test to make it compatible with reading the dom.xbl_scopes only once per global. v1

r=me
Attachment #716155 - Flags: review?(bzbarsky) → review+
Comment on attachment 716156 [details] [diff] [review]
Part 4 - Compute whether to use an XBL scope exactly once. v1

r=me
Attachment #716156 - Flags: review?(bzbarsky) → review+
Assignee

Comment 13

6 years ago
Comment on attachment 716156 [details] [diff] [review]
Part 4 - Compute whether to use an XBL scope exactly once. v1

See bug 844783 comment 53.
Attachment #716156 - Flags: approval-mozilla-aurora?
Assignee

Updated

6 years ago
Whiteboard: [leave uplift for bholley]
Attachment #716156 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [leave uplift for bholley]
You need to log in before you can comment on or make changes to this bug.