843231 - Compute whether to use XBL scopes exactly once

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

This will let us avoid doing work in certain cases, and reduces the refactoring required to define Components on the XBL scope.

Comment 1

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=13006f70a956

Comment 2

[Bobby Holley (:bholley)]

Attachment: Part 1 - Move the nulling out of mPrototypeNoHelper from SetGlobal to RemoveWrappedNativeProtos. v1

The only call-site for both of these is JSD->nsXPConnect::InitClasses, so this
is equivalent. All this will go away soon anyhow when JSD goes away.

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 2 - Remove SetGlobalObject. v1

This stuff has all been simplified significantly with CPG, and this is no longer
necessary. We always have a global when we construct a scope, and it never
changes.

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 3 - Alter the XBL scope test to make it compatible with reading the dom.xbl_scopes only once per global. v1

Comment 5

[Bobby Holley (:bholley)]

Attachment: Part 4 - Compute whether to use an XBL scope exactly once. v1

Comment 6

[Bobby Holley (:bholley)]

I figured out a simpler way to do the Components stuff so this no longer blocks, but it's a good thing to do anyway.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 716152 [details] [diff] [review]
Part 1 - Move the nulling out of mPrototypeNoHelper from SetGlobal to RemoveWrappedNativeProtos. v1

r=me

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 716153 [details] [diff] [review]
Part 2 - Remove SetGlobalObject. v1

It's called SetGlobal, not SetGlobalObject.

r=me with that, I guess.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 716155 [details] [diff] [review]
Part 3 - Alter the XBL scope test to make it compatible with reading the dom.xbl_scopes only once per global. v1

r=me

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 716156 [details] [diff] [review]
Part 4 - Compute whether to use an XBL scope exactly once. v1

r=me

Comment 11

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/35d293a7541d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/fe3729c8396d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/e177d717382f
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/b332047abd6c

Comment 12

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/35d293a7541d
https://hg.mozilla.org/mozilla-central/rev/fe3729c8396d
https://hg.mozilla.org/mozilla-central/rev/e177d717382f
https://hg.mozilla.org/mozilla-central/rev/b332047abd6c

Comment 13

[Bobby Holley (:bholley)]

Comment on attachment 716156 [details] [diff] [review]
Part 4 - Compute whether to use an XBL scope exactly once. v1

See bug 844783 comment 53.

Comment 14

[Bobby Holley (:bholley)]

remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/eecd27a66689
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/add20e9fce39
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/dedc70b52eaa
remote:   https://hg.mozilla.org/releases/mozilla-aurora/rev/033f2f8ee525