843272 - callback interface codegen silently ignores resultNotAddRefed

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrew McCreight [:mccr8] (PTO until 12-2)]

callback interface Foo {
  Foo receiveWeakSelf();
};

Bindings.conf:

'Foo' : {
        'resultNotAddRefed': [ 'receiveWeakSelf']
},

The return type of receieveWeakSelf ends up being |already_AddRefed<Foo>|, so it looks like the codegen is ignoring this setting.

I'm guessing it doesn't make any sense for a JS-implemented thing to return something that isn't addrefed, but it would be nice to at least throw an error in the binding generation code to say that this setting is being ignored.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Sure.

Comment 2

[Boris Zbarsky [:bzbarsky]]

So the tests commented out with this bug number can just be enabled as far as I can tell...

I think we should just throw if callback interface stuff is marked resultNotAddRefed.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Uncomment tests that should not be commented out

Per comment 2

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4660a2d871f1