Closed Bug 843272 Opened 7 years ago Closed 5 years ago

callback interface codegen silently ignores resultNotAddRefed

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla35

People

(Reporter: mccr8, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

callback interface Foo {
  Foo receiveWeakSelf();
};

Bindings.conf:

'Foo' : {
        'resultNotAddRefed': [ 'receiveWeakSelf']
},

The return type of receieveWeakSelf ends up being |already_AddRefed<Foo>|, so it looks like the codegen is ignoring this setting.

I'm guessing it doesn't make any sense for a JS-implemented thing to return something that isn't addrefed, but it would be nice to at least throw an error in the binding generation code to say that this setting is being ignored.
Summary: callback interface codegen silently ignores resultNotAddrefed → callback interface codegen silently ignores resultNotAddRefed
Sure.
So the tests commented out with this bug number can just be enabled as far as I can tell...

I think we should just throw if callback interface stuff is marked resultNotAddRefed.
Depends on: 849567
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8487644 - Flags: review?(continuation) → review+
https://hg.mozilla.org/mozilla-central/rev/4660a2d871f1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.