Closed
Bug 843332
Opened 11 years ago
Closed 11 years ago
Simplify nsBlockFrame::PullFrame/PullFrameFrom
Categories
(Core :: Layout: Block and Inline, defect)
Core
Layout: Block and Inline
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
References
Details
Attachments
(3 files)
6.09 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
4.50 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
1.04 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 1•11 years ago
|
||
Make PullFrame drain the overflow list before calling PullFrameFrom that can then be simplified to only deal with mList/mFrames.
Attachment #717486 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #717487 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 3•11 years ago
|
||
... 'true' also works because when pulling a frame from a next-in-flow the frame is appended and thus has no next-siblings, but I feel that 'false' is more correct here. https://tbpl.mozilla.org/?tree=Try&rev=e6b7441af95b
Attachment #717488 -
Flags: review?(bzbarsky)
Comment 4•11 years ago
|
||
Comment on attachment 717486 [details] [diff] [review] Call DrainSelfOverflowList() if mLines is empty >- NS_ASSERTION(frame->GetParent() == aFromContainer, "unexpected parent frame"); Why remove that? r=me
Attachment #717486 -
Flags: review?(bzbarsky) → review+
Comment 5•11 years ago
|
||
Comment on attachment 717487 [details] [diff] [review] Remove the use of aState in PullFrameFrom and add some assertions r=me; I guess this was working around the fact that appends on frame lists used to be slow?
Attachment #717487 -
Flags: review?(bzbarsky) → review+
Comment 6•11 years ago
|
||
Comment on attachment 717488 [details] [diff] [review] Pass 'false' to ReparentFloats since we only added one frame Worth adding a comment about why the last arg is false. r=me
Attachment #717488 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Boris Zbarsky (:bz) from comment #4) > >- NS_ASSERTION(frame->GetParent() == aFromContainer, "unexpected parent frame"); > > Why remove that? The ReparentFrame() call on the next line asserts that. (In reply to Boris Zbarsky (:bz) from comment #6) > Worth adding a comment about why the last arg is false. r=me done https://hg.mozilla.org/integration/mozilla-inbound/rev/8e7d5e9ee70a https://hg.mozilla.org/integration/mozilla-inbound/rev/df02eb97f4d1 https://hg.mozilla.org/integration/mozilla-inbound/rev/78b5b032d676
Comment 8•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8e7d5e9ee70a https://hg.mozilla.org/mozilla-central/rev/df02eb97f4d1 https://hg.mozilla.org/mozilla-central/rev/78b5b032d676
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•