GC: no need for getAllocKind in JSObject::finalize

RESOLVED FIXED in mozilla22

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

Trunk
mozilla22
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 716227 [details] [diff] [review]
v0

We used to have to check the background finalization kind before getting the class because the class is stored behind the shape. Since bug 838643, this is no longer necessary. This is good, because I am making getAllocKind slower in 841059. That bug regresses v8-early-boyer without this patch also applied.
Attachment #716227 - Flags: review?(jcoppeard)
Depends on: 838643
No longer depends on: 828643
(Assignee)

Comment 1

6 years ago
Created attachment 716236 [details] [diff] [review]
v1: This time working in debug builds too.
Attachment #716227 - Attachment is obsolete: true
Attachment #716227 - Flags: review?(jcoppeard)
Attachment #716236 - Flags: review?(jcoppeard)
Comment on attachment 716236 [details] [diff] [review]
v1: This time working in debug builds too.

Review of attachment 716236 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

This is similar to some changes I was doing in bug 841801 anyway, but this looks like it will land first.
Attachment #716236 - Flags: review?(jcoppeard) → review+
(Assignee)

Comment 3

6 years ago
Yeah, I saw it just a few minutes after I put this patch up for review. Sorry for busting your next merge. :-)

https://hg.mozilla.org/integration/mozilla-inbound/rev/710cfe8fed89
https://hg.mozilla.org/mozilla-central/rev/710cfe8fed89
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.