84334 - Unable to delete mail when stopped during deletion

Status: VERIFIED FIXED

(MailNews Core :: Networking: POP, defect, P1)

Description

[Sheela Ravindran]

Branch build :2001060511win98, 2001060504 linux build

Selecting large messages and hit stop before delete is complete.  This makes any 
further deletion impossible in that account.  This can be reproduced in a pop 
account. 

Steps to reproduce:
Start mail app
make sure you have a pop account in the profile.
send your self messages with large attachments
receive these messages in the inbox
select a bunch of messages with the above messages in the thread pane
(make sure messages are large so that you have time to stop the deletion)
Click on the delete button in the toolbar
Click on the stop button before it finishes deleting 
Later clear the selection in the thread pane.(Because when you stop the messages 
are still selected in the thread pane)


Actual Results: Trying to delete messages in inbox or any folders in that 
account fails.  Switching folders does nothing. Switching accounts also does not 
resolve the problem.  Trying to delete single or multiple messages again in the 
same session fails from menu item, toolbar, context menus.
I also saw that the copy of these messages were not cleared from the trash. I 
saw a few messages in the trash folder and those messages still in the thread 
pane.  So I guess when we stop deleting messages we do not clear the copy that 
me make in trash folder before deleting messages.

Expected result: None of the above. 

I still need to check this on mac and I will update the bug after I do so. 
Nominating this bug for nsbeta1 so that users are able to delete messages.  
There are several delete bugs which has been reported with no reproducible test 
case but just confusing comments.  So hopefully this is the same bug that others 
have been seeing.

Comment 1

[Sheela Ravindran]

Adding keyword 

Comment 2

[scottputterman]

Bugscape 5952 mentions something similar, I think.  Moving to 0.9.2

Comment 3

[scottputterman]

reassigning to cavin

Comment 4

[David :Bienvenu]

this is going to turn out to be because we're not clearing the copy state after
stopping the copy, I'd bet. Cc'ing Navin because he has several similar bugs.

Comment 5

[scottputterman]

adding PDT+

Comment 6

[Navin Gupta]

Cavin, I want to take this back if you have not started working on it. 
I am more familiar with this code. 

Comment 7

[Cavin Song]

OK, Navin you can have it back as I have not looked into it yet.

Comment 8

[Navin Gupta]

reassigning back to self

Comment 9

[Navin Gupta]

Attachment: proposed fix

Comment 10

[Navin Gupta]

Whenever copy is stopped truncate to the beginning of the last message and 
clear the copyState. Also remove this old code so that NS_BINDING_ABORTED can 
be propagated up to nsMsgProtocol and from there to the copy code. 

mscott, the necko code no longer returns NS_BINDING_ABORTED for displaying and 
copying msgs. looking for r & sr from david and mscott. 

Comment 11

[Scott MacGregor]

r=mscott

Comment 12

[David :Bienvenu]

sr=bienvenu

Comment 13

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 14

[Navin Gupta]

fix checked into trunk.

Comment 15

[Sheela Ravindran]

verified using the following builds:
2001061807-win98
2001061808-mac
2001061808-linux