843363 - nsDirectoryViewer.cpp:1172:11: warning: variable 'rv' set but not used [-Wunused-but-set-variable]

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Daniel Holbert [:dholbert]]

Newish build warning in GCC 4.7
{
xpfe/components/directory/nsDirectoryViewer.cpp: In member function 'virtual nsresult nsHTTPIndex::ArcLabelsOut(nsIRDFResource*, nsISimpleEnumerator**)':

xpfe/components/directory/nsDirectoryViewer.cpp:1172:11: warning: variable 'rv' set but not used [-Wunused-but-set-variable]
}

The code looks like this:
> 1169 NS_IMETHODIMP
> 1170 nsHTTPIndex::ArcLabelsOut(nsIRDFResource *aSource, nsISimpleEnumerator **_retval)
> 1171 {
> 1172 	nsresult	rv = NS_ERROR_UNEXPECTED;
[..]
> 1182 	if (mInner)
> 1183 	{
> 1184 		rv = mInner->ArcLabelsOut(aSource, getter_AddRefs(anonArcs));
> 1185 	}
> 1186 
> 1187 	return NS_NewUnionEnumerator(_retval, child, anonArcs);
> 1188 }

Bug 819936 removed the last use of this variable:
  https://hg.mozilla.org/mozilla-central/rev/08e6e5bc8b5f#l8.24

Should we be checking the ArcLabelsOut() return-value for success?

Comment 1

[Trevor Saunders (:tbsaunde)]

no clue

Comment 2

[:Cykesiopka]

(In reply to Trevor Saunders (:tbsaunde) from comment #1)
> no clue

Ok, thanks anyways.

Comment 3

[:Cykesiopka]

Attachment: Proposed Patch

Don't know if this is what should be done, but here's a patch that just removes the nsresult.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 785332 [details] [diff] [review]
Proposed Patch

Sure.  r=me

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c00ddc7c87ad

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c00ddc7c87ad

Comment 7

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336