843437 - Warning message in debug builds due to UA overrides

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Lawrence Mandel [:lmandel] (use needinfo)]

Dave Hylands noted in bug 827635 comment 1:
I'm seeing a ton of messages in the log files in debug builds:

20:01:55.616 635/635                     Gecko  I   WARNING: preserving unexpected JS escape sequence: file /home/dhylands/work/B2G-unagi/mozilla-inbound/modules/libpref/src/prefread.cpp, line 397

I added some more debug and one (of the many) prefs in question was:

pref_DoCallback 'general.useragent.override.facebook.com' value '\(Mobile#(Android; Mobile'


We can change the overrides either to '\\(Mobile#(Android; Mobile' or 'Mobile#Android; Mobile'.

Comment 1

[Dave Hylands [:dhylands]]

I'm guessing that we should be using one of these:

'\\(Mobile#(Android; Mobile' or '(Mobile#Android; Mobile'

but I don't know which one is appropriate.

Comment 2

[Dave Hylands [:dhylands]]

I just read your comment in bug 827635 about '(Mobile#Android; Mobile' not working. So I'll shutup now. You can ignore comment 1.

Comment 3

[Lawrence Mandel [:lmandel] (use needinfo)]

Attachment: Correct the UA overrides to prevent warning messages

Comment 4

[Dave Hylands [:dhylands]]

Comment on attachment 742522 [details] [diff] [review]
Correct the UA overrides to prevent warning messages

Review of attachment 742522 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

I verified that the warnings go away in a debug build.

I'm not sure how to test if the UA overrides are still working, so I'll assume that you've done that.

Comment 5

[Lawrence Mandel [:lmandel] (use needinfo)]

Spot testing shows the patch to be effective.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

John, can you land this please?

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

This patch doesn't apply on master branch, unfortunately.

Did you use a sed script to do this patch?  If so, it might make sense for you to provide that sed script and I can run it when I commit.

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

I didn't use a sed script. As I only noticed this was sitting two weeks later, I wonder if the patch is just out of date. I'll take a look.

Comment 9

[Lawrence Mandel [:lmandel] (use needinfo)]

Attachment: Cleanup UA override warnings - take 2

Dave, can you please review to confirm that the warnings no longer appear after applying this patch?

Comment 10

[Dave Hylands [:dhylands]]

Comment on attachment 759915 [details] [diff] [review]
Cleanup UA override warnings - take 2

Review of attachment 759915 [details] [diff] [review]:
-----------------------------------------------------------------

I can confirm that the "WARNING: preserving unexpected JS escape sequence: file /home/work/B2G-unagi/birch/modules/libpref/src/prefread.cpp, line 393" messages no longer appear with this patch applied.

Comment 11

[Dave Hylands [:dhylands]]

I tested on my unagi against master.

Comment 12

[Lawrence Mandel [:lmandel] (use needinfo)]

Thanks Dave!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Let's try that again!

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

https://github.com/mozilla-b2g/gaia/commit/db513280d3d8c05f755cc6b92d7e5dcdaa505dba