Last Comment Bug 843489 - [Progress Events] Remove support for ProgressEvent.initProgressEvent() and Document.createEvent("ProgressEvent")
: [Progress Events] Remove support for ProgressEvent.initProgressEvent() and Do...
: dev-doc-complete, site-compat
Product: Core
Classification: Components
Component: DOM: Events (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla22
Assigned To: Masatoshi Kimura [:emk]
Depends on: 870466
  Show dependency treegraph
Reported: 2013-02-20 23:45 PST by Jungkee Song
Modified: 2013-08-27 05:49 PDT (History)
9 users (show)
VYV03354: in‑testsuite?
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Make initProgressEvent() [noscript] (1.73 KB, patch)
2013-02-22 14:57 PST, Masatoshi Kimura [:emk]
bugs: review-
Details | Diff | Review
Drop support for .createEvent("progressevent") (3.63 KB, patch)
2013-02-22 16:51 PST, Masatoshi Kimura [:emk]
bugs: review+
Details | Diff | Review

Description Jungkee Song 2013-02-20 23:45:48 PST
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.70 Safari/537.17

Steps to reproduce:

ProgressEvent CR ( test
- Test wiki:
- Test suite:
- Test case:

Actual results:

Test case failed: Object created from ProgressEvent interface has a initProgressEvent() method.

Expected results:

Object created from ProgressEvent interface should not have initProgressEvent() method anymore.

initProgressEvent() had been present until
<> version and removed
from <> version. As
it's been replaced by constructor, it may not be supported any more.
Comment 1 Alex Vincent [:WeirdAl] 2013-02-21 00:01:22 PST
Thanks for the cc, though I'm not sure why you cc'd me...

What do the WHATWG specs say on this?
Comment 2 Masatoshi Kimura [:emk] 2013-02-21 00:17:23 PST
WHATWG spec no longer defines initProgressEvent, either.
Comment 3 Masatoshi Kimura [:emk] 2013-02-21 00:22:56 PST
Also, WebKit already removed initProgressEvent.
Comment 4 Olli Pettay [:smaug] 2013-02-21 01:52:09 PST
This bug is valid, but odd testcase. What if some "LegacyEvents" spec added initProgressEvent.
Implementing such spec without causing test failures wouldn't be possible.
Comment 5 :Ms2ger 2013-02-21 02:00:48 PST
If that happens, I'll happily update the test :)
Comment 6 Masatoshi Kimura [:emk] 2013-02-22 14:57:28 PST
Created attachment 717343 [details] [diff] [review]
Make initProgressEvent() [noscript]

I left the function for C++ callers because the ProgressEvent constructor is hard to call from C++.
I didn't bump the iid because this will not change the binary layout.
Comment 7 Olli Pettay [:smaug] 2013-02-22 16:04:18 PST
Comment on attachment 717343 [details] [diff] [review]
Make initProgressEvent() [noscript]

Do other browser have initProgressEvent?
Comment 8 Masatoshi Kimura [:emk] 2013-02-22 16:17:10 PST
Ms2ger's test should be imported.

(In reply to Olli Pettay [:smaug] from comment #7)
> Do other browser have initProgressEvent?

Chrome does not support initProgressEvent (see comment #3).
IE10 has initProgressEvent, but it doesn't support ProgressEvent in the first place.
I don't care about dying Presto anymore.
Comment 9 Masatoshi Kimura [:emk] 2013-02-22 16:18:14 PST
> it doesn't support ProgressEvent
it doesn't support ProgressEvent constructor
Comment 10 Olli Pettay [:smaug] 2013-02-22 16:19:32 PST
Comment on attachment 717343 [details] [diff] [review]
Make initProgressEvent() [noscript]

Actually, since we support .createEvent("progressevent"), we should have
initProgressEvent too.
So either remove both or keep them both.
Comment 11 Masatoshi Kimura [:emk] 2013-02-22 16:51:33 PST
Created attachment 717404 [details] [diff] [review]
Drop support for .createEvent("progressevent")
Comment 12 Olli Pettay [:smaug] 2013-02-22 17:02:49 PST
Comment on attachment 717404 [details] [diff] [review]
Drop support for .createEvent("progressevent")

This all is tiny bit risky since IE supports this.
But better to try this now, early in cycle.
Comment 15 Kohei Yoshino [:kohei] 2013-03-29 10:16:04 PDT
I've added this bug to the compatibility doc. Please correct the info if wrong.

Note You need to log in before you can comment on or make changes to this bug.