843489 - [Progress Events] Remove support for ProgressEvent.initProgressEvent() and Document.createEvent("ProgressEvent")

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Jungkee Song]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.70 Safari/537.17

Steps to reproduce:

ProgressEvent CR (http://www.w3.org/TR/progress-events/) test
- Test wiki: http://www.w3.org/wiki/Webapps/Interop/ProgressEvents
- Test suite: http://w3c-test.org/webapps/ProgressEvents/tests/
- Test case: http://w3c-test.org/webapps/ProgressEvents/tests/submissions/Ms2ger/constructor.html



Actual results:

Test case failed: Object created from ProgressEvent interface has a initProgressEvent() method.


Expected results:

Object created from ProgressEvent interface should not have initProgressEvent() method anymore.

initProgressEvent() had been present until
<http://www.w3.org/TR/2011/WD-progress-events-20110310/> version and removed
from <http://www.w3.org/TR/2011/WD-progress-events-20110809/> version. As
it's been replaced by constructor, it may not be supported any more.

Comment 1

[Alex Vincent [:WeirdAl]]

Thanks for the cc, though I'm not sure why you cc'd me...

What do the WHATWG specs say on this?

Comment 2

[Masatoshi Kimura [:emk]]

WHATWG spec no longer defines initProgressEvent, either.
http://xhr.spec.whatwg.org/#interface-progressevent

Comment 3

[Masatoshi Kimura [:emk]]

Also, WebKit already removed initProgressEvent.
https://bugs.webkit.org/show_bug.cgi?id=71340

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

This bug is valid, but odd testcase. What if some "LegacyEvents" spec added initProgressEvent.
Implementing such spec without causing test failures wouldn't be possible.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

If that happens, I'll happily update the test :)

Comment 6

[Masatoshi Kimura [:emk]]

Attachment: Make initProgressEvent() [noscript]

I left the function for C++ callers because the ProgressEvent constructor is hard to call from C++.
I didn't bump the iid because this will not change the binary layout.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 717343 [details] [diff] [review]
Make initProgressEvent() [noscript]

Do other browser have initProgressEvent?

Comment 8

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/64d47c0e35a8
Ms2ger's test should be imported.

(In reply to Olli Pettay [:smaug] from comment #7)
> Do other browser have initProgressEvent?

Chrome does not support initProgressEvent (see comment #3).
IE10 has initProgressEvent, but it doesn't support ProgressEvent in the first place.
I don't care about dying Presto anymore.

Comment 9

[Masatoshi Kimura [:emk]]

> it doesn't support ProgressEvent
it doesn't support ProgressEvent constructor

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 717343 [details] [diff] [review]
Make initProgressEvent() [noscript]

Actually, since we support .createEvent("progressevent"), we should have
initProgressEvent too.
So either remove both or keep them both.

Comment 11

[Masatoshi Kimura [:emk]]

Attachment: Drop support for .createEvent("progressevent")

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 717404 [details] [diff] [review]
Drop support for .createEvent("progressevent")

This all is tiny bit risky since IE supports this.
But better to try this now, early in cycle.

Comment 13

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c2c1e378ab49

Comment 14

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/64d47c0e35a8
https://hg.mozilla.org/mozilla-central/rev/c2c1e378ab49

Comment 15

[Kohei Yoshino [:kohei]]

I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_22

Comment 16

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

We need an update to https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/NsIDOMProgressEvent too.

Comment 17

[Jean-Yves Perrier [:teoli]]

Updated:
https://developer.mozilla.org/en-US/docs/Web/API/ProgressEvent.initProgressEvent
https://developer.mozilla.org/en-US/docs/Web/API/ProgressEvent
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/22
https://developer.mozilla.org/en-US/docs/Web/API/document.createEvent (this article is in need of a complete rewrite, so I did the minimum here)
and
https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/NsIDOMProgressEvent