Last Comment Bug 843489 - [Progress Events] Remove support for ProgressEvent.initProgressEvent() and Document.createEvent("ProgressEvent")
: [Progress Events] Remove support for ProgressEvent.initProgressEvent() and Do...
Status: RESOLVED FIXED
: dev-doc-complete, site-compat
Product: Core
Classification: Components
Component: DOM: Events (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla22
Assigned To: Masatoshi Kimura [:emk]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on: 1314303 870466
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-20 23:45 PST by Jungkee Song
Modified: 2016-11-01 09:01 PDT (History)
9 users (show)
VYV03354: in‑testsuite?
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Make initProgressEvent() [noscript] (1.73 KB, patch)
2013-02-22 14:57 PST, Masatoshi Kimura [:emk]
bugs: review-
Details | Diff | Splinter Review
Drop support for .createEvent("progressevent") (3.63 KB, patch)
2013-02-22 16:51 PST, Masatoshi Kimura [:emk]
bugs: review+
Details | Diff | Splinter Review

Description Jungkee Song 2013-02-20 23:45:48 PST
User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.17 (KHTML, like Gecko) Chrome/24.0.1312.70 Safari/537.17

Steps to reproduce:

ProgressEvent CR (http://www.w3.org/TR/progress-events/) test
- Test wiki: http://www.w3.org/wiki/Webapps/Interop/ProgressEvents
- Test suite: http://w3c-test.org/webapps/ProgressEvents/tests/
- Test case: http://w3c-test.org/webapps/ProgressEvents/tests/submissions/Ms2ger/constructor.html



Actual results:

Test case failed: Object created from ProgressEvent interface has a initProgressEvent() method.


Expected results:

Object created from ProgressEvent interface should not have initProgressEvent() method anymore.

initProgressEvent() had been present until
<http://www.w3.org/TR/2011/WD-progress-events-20110310/> version and removed
from <http://www.w3.org/TR/2011/WD-progress-events-20110809/> version. As
it's been replaced by constructor, it may not be supported any more.
Comment 1 Alex Vincent [:WeirdAl] 2013-02-21 00:01:22 PST
Thanks for the cc, though I'm not sure why you cc'd me...

What do the WHATWG specs say on this?
Comment 2 Masatoshi Kimura [:emk] 2013-02-21 00:17:23 PST
WHATWG spec no longer defines initProgressEvent, either.
http://xhr.spec.whatwg.org/#interface-progressevent
Comment 3 Masatoshi Kimura [:emk] 2013-02-21 00:22:56 PST
Also, WebKit already removed initProgressEvent.
https://bugs.webkit.org/show_bug.cgi?id=71340
Comment 4 Olli Pettay [:smaug] 2013-02-21 01:52:09 PST
This bug is valid, but odd testcase. What if some "LegacyEvents" spec added initProgressEvent.
Implementing such spec without causing test failures wouldn't be possible.
Comment 5 :Ms2ger (⌚ UTC+1/+2) 2013-02-21 02:00:48 PST
If that happens, I'll happily update the test :)
Comment 6 Masatoshi Kimura [:emk] 2013-02-22 14:57:28 PST
Created attachment 717343 [details] [diff] [review]
Make initProgressEvent() [noscript]

I left the function for C++ callers because the ProgressEvent constructor is hard to call from C++.
I didn't bump the iid because this will not change the binary layout.
Comment 7 Olli Pettay [:smaug] 2013-02-22 16:04:18 PST
Comment on attachment 717343 [details] [diff] [review]
Make initProgressEvent() [noscript]

Do other browser have initProgressEvent?
Comment 8 Masatoshi Kimura [:emk] 2013-02-22 16:17:10 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/64d47c0e35a8
Ms2ger's test should be imported.

(In reply to Olli Pettay [:smaug] from comment #7)
> Do other browser have initProgressEvent?

Chrome does not support initProgressEvent (see comment #3).
IE10 has initProgressEvent, but it doesn't support ProgressEvent in the first place.
I don't care about dying Presto anymore.
Comment 9 Masatoshi Kimura [:emk] 2013-02-22 16:18:14 PST
> it doesn't support ProgressEvent
it doesn't support ProgressEvent constructor
Comment 10 Olli Pettay [:smaug] 2013-02-22 16:19:32 PST
Comment on attachment 717343 [details] [diff] [review]
Make initProgressEvent() [noscript]

Actually, since we support .createEvent("progressevent"), we should have
initProgressEvent too.
So either remove both or keep them both.
Comment 11 Masatoshi Kimura [:emk] 2013-02-22 16:51:33 PST
Created attachment 717404 [details] [diff] [review]
Drop support for .createEvent("progressevent")
Comment 12 Olli Pettay [:smaug] 2013-02-22 17:02:49 PST
Comment on attachment 717404 [details] [diff] [review]
Drop support for .createEvent("progressevent")

This all is tiny bit risky since IE supports this.
But better to try this now, early in cycle.
Comment 15 Kohei Yoshino [:kohei] 2013-03-29 10:16:04 PDT
I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_22
Comment 16 :Ms2ger (⌚ UTC+1/+2) 2013-03-30 06:15:52 PDT
We need an update to https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/NsIDOMProgressEvent too.

Note You need to log in before you can comment on or make changes to this bug.