Closed Bug 843579 Opened 8 years ago Closed 4 years ago

Remove prefix from :any-link

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: annevk, Assigned: wisniewskit)

References

(Blocks 2 open bugs, )

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file, 1 obsolete file)

We should remove the prefix here so people can start using it normally. Using :link:visited is annoying.
Blocks: selectors-4
OS: Mac OS X → All
Hardware: x86 → All
I'm assuming it's still too early to un-prefix this, given that the spec is still a draft, and has a big "any better name suggestions for this pseudo?" note on it? If not, I wouldn't mind helping unprefix this.
Flags: needinfo?(annevk)
Thomas, see https://www.w3.org/Bugs/Public/show_bug.cgi?id=21070 (and the duplicate I filed which says much the same) for why we should just go ahead and unprefix this.
Flags: needinfo?(annevk)
Would it be worth keeping the prefixed version around as well as a deprecation measure? I see almost no mention of the property online, so I don't suspect it has seen much use yet.
Flags: needinfo?(annevk)
I think for add-ons we might have to keep it around, not for web. David would know best though.
Flags: needinfo?(annevk) → needinfo?(dbaron)
While we decide, here's a patch that supports both the prefixed and unprefixed version.

A try run only shows unrelated intermittents: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f312c95396f&selectedJob=24162865
Assignee: nobody → wisniewskit
Status: NEW → ASSIGNED
Attachment #8772636 - Flags: review?(bzbarsky)
Comment on attachment 8772636 [details] [diff] [review]
843579-unprefix_-moz-any-link.diff

http://searchfox.org/mozilla-central/rev/65bed54efcce67cf04a890f7fe253ccdfa6befdc/layout/inspector/tests/chrome/test_bug708874.xul#246 needs adjusting too, right?

r=me with that, but please send an intent to ship per the instructions at https://wiki.mozilla.org/WebAPI/ExposureGuidelines#Intent_to_Ship
Attachment #8772636 - Flags: review?(bzbarsky) → review+
Sure, here's a version which revises the test to use ":ny-link" instead of ":moz-any-link" (without the leading hyphen, since it's testing for an invalid pseudo-class). Carrying over r+.

But should I be the one to write up the intent-to-ship? I certainly don't mind, but I'm not officially a Mozilla employee (though I will be applying sometime).
Flags: needinfo?(dbaron) → needinfo?(bzbarsky)
Attachment #8772636 - Attachment is obsolete: true
You don't need to be an employee to send an intent to ship.  ;)

If you'd rather, I can write one up, but there's no real reason it can't be you other than your comfort level.
Flags: needinfo?(bzbarsky)
No problem, I just wanted to make sure.

Email sent, requesting checkin.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/cae3143edbd4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Just FYI, my Intent to Ship email is probably stuck in a moderator queue, as I received the obligatory "you're new, so a mod has to vet your email" notice when I sent it, and I'm still not seeing it on https://groups.google.com/forum/?_escaped_fragment_=forum/mozilla.dev.platform#!forum/mozilla.dev.platform

I'm not sure who to nudge about that, but I thought I'd at least let you know for starters.
Flags: needinfo?(bzbarsky)
Hrm.  Looks like the dev.platform moderator is out until August 2 according to his bugzilla name.  That's not very useful...

For future reference, if you're subscribed to the list the mail will just go through, I believe.  But for the time being, want to send me the mail and I'll send it to the list for you?
Flags: needinfo?(bzbarsky) → needinfo?(wisniewskit)
Sure, here's a fresh email (sorry that I let this ni slip for a few days):

Intent to ship: CSS4 :any-link pseudo-class

As of Firefox 50, I intend to unprefix the CSS4 :any-link pseudo-class by default on all platforms. This has been shipped as :-moz-any-link for years, and matches its spec (see https://www.w3.org/Bugs/Public/show_bug.cgi?id=21070). The prefixed version will also remain active. WebKit/Blink have also been shipping it with their own prefix, :-webkit-any-link.

Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=843579
Link to standard: https://drafts.csswg.org/selectors/#the-any-link-pseudo
Flags: needinfo?(wisniewskit)
Thanks, sent.
Blocks: unprefix
You need to log in before you can comment on or make changes to this bug.