843579 - Remove prefix from :any-link

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Anne (:annevk)]

We should remove the prefix here so people can start using it normally. Using :link:visited is annoying.

Comment 2

[Thomas Wisniewski]

I'm assuming it's still too early to un-prefix this, given that the spec is still a draft, and has a big "any better name suggestions for this pseudo?" note on it? If not, I wouldn't mind helping unprefix this.

Comment 3

[Anne (:annevk)]

Thomas, see https://www.w3.org/Bugs/Public/show_bug.cgi?id=21070 (and the duplicate I filed which says much the same) for why we should just go ahead and unprefix this.

Comment 4

[Thomas Wisniewski]

Would it be worth keeping the prefixed version around as well as a deprecation measure? I see almost no mention of the property online, so I don't suspect it has seen much use yet.

Comment 5

[Anne (:annevk)]

I think for add-ons we might have to keep it around, not for web. David would know best though.

Comment 6

[Thomas Wisniewski]

Attachment: 843579-unprefix_-moz-any-link.diff

While we decide, here's a patch that supports both the prefixed and unprefixed version.

A try run only shows unrelated intermittents: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f312c95396f&selectedJob=24162865

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8772636 [details] [diff] [review]
843579-unprefix_-moz-any-link.diff

http://searchfox.org/mozilla-central/rev/65bed54efcce67cf04a890f7fe253ccdfa6befdc/layout/inspector/tests/chrome/test_bug708874.xul#246 needs adjusting too, right?

r=me with that, but please send an intent to ship per the instructions at https://wiki.mozilla.org/WebAPI/ExposureGuidelines#Intent_to_Ship

Comment 8

[Thomas Wisniewski]

Attachment: 843579-unprefix_-moz-any-link.diff

Sure, here's a version which revises the test to use ":ny-link" instead of ":moz-any-link" (without the leading hyphen, since it's testing for an invalid pseudo-class). Carrying over r+.

But should I be the one to write up the intent-to-ship? I certainly don't mind, but I'm not officially a Mozilla employee (though I will be applying sometime).

Comment 9

[Boris Zbarsky [:bzbarsky]]

You don't need to be an employee to send an intent to ship.  ;)

If you'd rather, I can write one up, but there's no real reason it can't be you other than your comfort level.

Comment 10

[Thomas Wisniewski]

No problem, I just wanted to make sure.

Email sent, requesting checkin.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cae3143edbd4
Unprefix -moz-any-link. r=bz

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cae3143edbd4

Comment 13

[Sebastian Zartner [:sebo]]

Added the description for this at https://developer.mozilla.org/en-US/docs/Web/CSS/:any-link and a release note at https://developer.mozilla.org/en-US/Firefox/Releases/50#CSS.

Sebastian

Comment 14

[Thomas Wisniewski]

Just FYI, my Intent to Ship email is probably stuck in a moderator queue, as I received the obligatory "you're new, so a mod has to vet your email" notice when I sent it, and I'm still not seeing it on https://groups.google.com/forum/?_escaped_fragment_=forum/mozilla.dev.platform#!forum/mozilla.dev.platform

I'm not sure who to nudge about that, but I thought I'd at least let you know for starters.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Hrm.  Looks like the dev.platform moderator is out until August 2 according to his bugzilla name.  That's not very useful...

For future reference, if you're subscribed to the list the mail will just go through, I believe.  But for the time being, want to send me the mail and I'll send it to the list for you?

Comment 16

[Thomas Wisniewski]

Sure, here's a fresh email (sorry that I let this ni slip for a few days):

Intent to ship: CSS4 :any-link pseudo-class

As of Firefox 50, I intend to unprefix the CSS4 :any-link pseudo-class by default on all platforms. This has been shipped as :-moz-any-link for years, and matches its spec (see https://www.w3.org/Bugs/Public/show_bug.cgi?id=21070). The prefixed version will also remain active. WebKit/Blink have also been shipping it with their own prefix, :-webkit-any-link.

Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=843579
Link to standard: https://drafts.csswg.org/selectors/#the-any-link-pseudo

Comment 17

[Boris Zbarsky [:bzbarsky]]

Thanks, sent.

Comment 18

[Kohei Yoshino [:kohei]]

Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/any-link-css-pseudo-class-has-been-unprefixed/