Closed Bug 843586 Opened 12 years ago Closed 12 years ago

Add telemetry flag for "character encoding menu used"

Categories

(Core :: DOM: Navigation, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 840476

People

(Reporter: hsivonen, Assigned: hsivonen)

References

Details

Attachments

(1 file)

To gather data about whether/when we can retire the character encoding menu, we should add a telemetry flag for measuring if it has been used in the browser session.
Attached patch Add the flagSplinter Review
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Attachment #716532 - Flags: review?(bugs)
Flags: needinfo?(sstamm)
If it's just a "yes/no" about whether or not it's been activated, this is pretty clearly measuring feature usage and is in scope. Please flag curtisk for future privacy reviews. Curtis: do you need to do anything else here?
Flags: needinfo?(sstamm) → needinfo?(curtisk)
other than adding this to the chart for telemetry (https://wiki.mozilla.org/Privacy/Reviews/Telemetry/Measurements) no I don't think so.
Flags: needinfo?(curtisk)
Comment on attachment 716532 [details] [diff] [review] Add the flag Ok, this is just a flag.
Attachment #716532 - Flags: review?(bugs) → review+
As discussed on IRC, the probe doesn't exactly handle only menu UI, since addons may and do use docshell.charset. So if better probe is needed, it should go to browser UI code.
Folded this into the new patch for bug 840476 which addresses the add-on issue.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: