Closed Bug 843638 Opened 10 years ago Closed 10 years ago

Uplift Add-on SDK stabilization branch to Aurora


(Firefox :: General, defect, P1)




Tracking Status
firefox21 --- fixed


(Reporter: mossop, Assigned: mossop)




(1 file)

This would bring in these changesets:

These cover:

Bug 819454: A P1 Snappy bug to speed up shutdown
Bug 793925: Support loading Jetpack APIs from Firefox for add-ons
Bug 842702: A minor fix for the context-menu API
There's probably going to be more than what's included in 1.14b3, so lets hold on this for a bit.
Priority: -- → P1
Summary: Uplift Aurora to Add-on SDK 1.14b3 → Uplift Add-on SDK 1.14b3 to Aurora
Update, will now be these changesets:

In addition to those mentioned in comment 0 that brings:

Bug 836930: A small leak fix
Bug 842111: An intermittent test failure fix (test only fix)
Bug 831933: An intermittent test failure fix (test only fix)
Summary: Uplift Add-on SDK 1.14b3 to Aurora → Uplift Add-on SDK stabilization branch to Aurora
Attached patch uplift patchSplinter Review
Uplift patch, flagging as reviewed as all this code was reviewed in our git repo.
Attachment #717945 - Flags: review+
Product: Add-on SDK → Firefox
Comment on attachment 717945 [details] [diff] [review]
uplift patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: Add-on developers will have to keep repacking their add-ons until this work ships
Testing completed (on m-c, etc.): All parts of this patch have been on m-c since late last week
Risk to taking this patch (and alternatives if risky): Very low risk, see explanation below
String or UUID changes made by this patch: None

This is an uplift of the SDK APIs and tests currently on our stabilization branch. It has been run through try and passed all tests. None of the changes here are actually used by Firefox code so the risk to Firefox itself is basically zero. Once these changes have landed though we can make add-ons use the shipped APIs which makes it easier for us to deploy stability and security fixes to add-ons without developers needing to repack their add-ons.

If we were to determine that the APIs in Firefox are faulty in some way then we can switch off their use from the SDK side without needing to take a change to Firefox.
Attachment #717945 - Flags: approval-mozilla-aurora?
Comment on attachment 717945 [details] [diff] [review]
uplift patch

Approving for aurora(Fx21) as we need Bug 793925 discussed on email with Jeff
Attachment #717945 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.