843638 - Uplift Add-on SDK stabilization branch to Aurora

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[Dave Townsend [:mossop]]

This would bring in these changesets: https://github.com/mozilla/addon-sdk/compare/4e44dd094e8636216e8c9ca5664866a5cf7d0cdd...f496376919260068e21addc05e962ab49ee40cb8

These cover:

Bug 819454: A P1 Snappy bug to speed up shutdown
Bug 793925: Support loading Jetpack APIs from Firefox for add-ons
Bug 842702: A minor fix for the context-menu API

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

There's probably going to be more than what's included in 1.14b3, so lets hold on this for a bit.

Comment 2

[Dave Townsend [:mossop]]

Update, will now be these changesets: https://github.com/mozilla/addon-sdk/compare/4e44dd094e8636216e8c9ca5664866a5cf7d0cdd...b563e7dd1c882eccfacdec1171758e03f6e044f5

In addition to those mentioned in comment 0 that brings:

Bug 836930: A small leak fix
Bug 842111: An intermittent test failure fix (test only fix)
Bug 831933: An intermittent test failure fix (test only fix)

Comment 3

[Dave Townsend [:mossop]]

Attachment: uplift patch

Uplift patch, flagging as reviewed as all this code was reviewed in our git repo.

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 717945 [details] [diff] [review]
uplift patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: Add-on developers will have to keep repacking their add-ons until this work ships
Testing completed (on m-c, etc.): All parts of this patch have been on m-c since late last week
Risk to taking this patch (and alternatives if risky): Very low risk, see explanation below
String or UUID changes made by this patch: None

This is an uplift of the SDK APIs and tests currently on our stabilization branch. It has been run through try and passed all tests. None of the changes here are actually used by Firefox code so the risk to Firefox itself is basically zero. Once these changes have landed though we can make add-ons use the shipped APIs which makes it easier for us to deploy stability and security fixes to add-ons without developers needing to repack their add-ons.

If we were to determine that the APIs in Firefox are faulty in some way then we can switch off their use from the SDK side without needing to take a change to Firefox.

Comment 5

[bhavana bajaj [:bajaj]]

Comment on attachment 717945 [details] [diff] [review]
uplift patch

Approving for aurora(Fx21) as we need Bug 793925 discussed on email with Jeff

Comment 6

[Dave Townsend [:mossop]]

Pushed: https://hg.mozilla.org/releases/mozilla-aurora/rev/66736a53ee17