Add ParallelDo() intrinsic in preparation for move to self-hosted ParallelArray

RESOLVED FIXED in mozilla22

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: nmatsakis, Unassigned)

Tracking

Trunk
mozilla22
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

6 years ago
This used to be part of bug 829602 but I am breaking that bug up because it proved to be too large.
(Reporter)

Updated

6 years ago
Blocks: 829602
(Reporter)

Comment 1

6 years ago
Created attachment 717650 [details] [diff] [review]
Add intrinsics for self-hosted ParallelArray.js

Carrying over from attachments to bug 829602
Attachment #717650 - Flags: review+
(Reporter)

Comment 2

6 years ago
Created attachment 717651 [details] [diff] [review]
Add definition of ParallelDo()

Carrying over from attachment on bug 829602
Attachment #717651 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/57449cdf45ad
https://hg.mozilla.org/mozilla-central/rev/8b45c1a642df
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
clang 3.2 gives me this:

/home/njn/moz/mi9/js/src/vm/ParallelDo.cpp:507:32: error: variable has
      incomplete type 'js::ion::ParallelCompileContext'
        ParallelCompileContext compileContext(cx_);
                               ^
../ion/Ion.h:22:7: note: forward declaration of
      'js::ion::ParallelCompileContext'
class ParallelCompileContext; // in ParallelArrayAnalysis.h
      ^
GCC 4.7 complains too:

/home/njn/moz/mi9/js/src/vm/ParallelDo.cpp: In member function ‘js::ion::MethodStatus ParallelDo::compileForParallelExecution()’:
/home/njn/moz/mi9/js/src/vm/ParallelDo.cpp:507:50: error: variable ‘js::ion::ParallelCompileContext compileContext’ has initializer but incomplete type
SelfHosting.cpp
You have this:

  #if defined(JS_THREADSAFE) && defined(JS_ION)
  #include "ion/ParallelArrayAnalysis.h"
  #endif // THREADSAFE && ION

Looks like the |defined(JS_THREADSAFE) &&| part needs to be removed.  r=me to do so, thanks.
(Reporter)

Updated

6 years ago
No longer blocks: 829602
You need to log in before you can comment on or make changes to this bug.