843684 - Add ParallelDo() intrinsic in preparation for move to self-hosted ParallelArray

Status: RESOLVED FIXED

Description

[Niko Matsakis [:nmatsakis]]

This used to be part of bug 829602 but I am breaking that bug up because it proved to be too large.

Comment 1

[Niko Matsakis [:nmatsakis]]

Created attachment 717650 [details] [diff] [review]
Add intrinsics for self-hosted ParallelArray.js

Carrying over from attachments to bug 829602

Comment 2

[Niko Matsakis [:nmatsakis]]

Created attachment 717651 [details] [diff] [review]
Add definition of ParallelDo()

Carrying over from attachment on bug 829602

Comment 3

[Niko Matsakis [:nmatsakis]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57449cdf45ad
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b45c1a642df

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/57449cdf45ad
https://hg.mozilla.org/mozilla-central/rev/8b45c1a642df

Comment 5

[Nicholas Nethercote [:njn]]

clang 3.2 gives me this:

/home/njn/moz/mi9/js/src/vm/ParallelDo.cpp:507:32: error: variable has
      incomplete type 'js::ion::ParallelCompileContext'
        ParallelCompileContext compileContext(cx_);
                               ^
../ion/Ion.h:22:7: note: forward declaration of
      'js::ion::ParallelCompileContext'
class ParallelCompileContext; // in ParallelArrayAnalysis.h
      ^

Comment 6

[Nicholas Nethercote [:njn]]

GCC 4.7 complains too:

/home/njn/moz/mi9/js/src/vm/ParallelDo.cpp: In member function ‘js::ion::MethodStatus ParallelDo::compileForParallelExecution()’:
/home/njn/moz/mi9/js/src/vm/ParallelDo.cpp:507:50: error: variable ‘js::ion::ParallelCompileContext compileContext’ has initializer but incomplete type
SelfHosting.cpp

Comment 7

[Nicholas Nethercote [:njn]]

You have this:

  #if defined(JS_THREADSAFE) && defined(JS_ION)
  #include "ion/ParallelArrayAnalysis.h"
  #endif // THREADSAFE && ION

Looks like the |defined(JS_THREADSAFE) &&| part needs to be removed.  r=me to do so, thanks.

Comment 8

[Niko Matsakis [:nmatsakis]]

:njn -- pushed that change:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca0d05c99758

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0a2f97ef16c

Uplifted to m-c to un-break our fuzzers.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca0d05c99758