Closed
Bug 843684
Opened 12 years ago
Closed 12 years ago
Add ParallelDo() intrinsic in preparation for move to self-hosted ParallelArray
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: nmatsakis, Unassigned)
Details
Attachments
(2 files)
10.08 KB,
patch
|
nmatsakis
:
review+
|
Details | Diff | Splinter Review |
14.08 KB,
patch
|
nmatsakis
:
review+
|
Details | Diff | Splinter Review |
This used to be part of bug 829602 but I am breaking that bug up because it proved to be too large.
Reporter | ||
Comment 1•12 years ago
|
||
Carrying over from attachments to bug 829602
Attachment #717650 -
Flags: review+
Reporter | ||
Comment 2•12 years ago
|
||
Carrying over from attachment on bug 829602
Attachment #717651 -
Flags: review+
Reporter | ||
Comment 3•12 years ago
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/57449cdf45ad
https://hg.mozilla.org/mozilla-central/rev/8b45c1a642df
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
![]() |
||
Comment 5•12 years ago
|
||
clang 3.2 gives me this:
/home/njn/moz/mi9/js/src/vm/ParallelDo.cpp:507:32: error: variable has
incomplete type 'js::ion::ParallelCompileContext'
ParallelCompileContext compileContext(cx_);
^
../ion/Ion.h:22:7: note: forward declaration of
'js::ion::ParallelCompileContext'
class ParallelCompileContext; // in ParallelArrayAnalysis.h
^
![]() |
||
Comment 6•12 years ago
|
||
GCC 4.7 complains too:
/home/njn/moz/mi9/js/src/vm/ParallelDo.cpp: In member function ‘js::ion::MethodStatus ParallelDo::compileForParallelExecution()’:
/home/njn/moz/mi9/js/src/vm/ParallelDo.cpp:507:50: error: variable ‘js::ion::ParallelCompileContext compileContext’ has initializer but incomplete type
SelfHosting.cpp
![]() |
||
Comment 7•12 years ago
|
||
You have this:
#if defined(JS_THREADSAFE) && defined(JS_ION)
#include "ion/ParallelArrayAnalysis.h"
#endif // THREADSAFE && ION
Looks like the |defined(JS_THREADSAFE) &&| part needs to be removed. r=me to do so, thanks.
Reporter | ||
Comment 8•12 years ago
|
||
:njn -- pushed that change:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca0d05c99758
Comment 9•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a0a2f97ef16c
Uplifted to m-c to un-break our fuzzers.
Comment 10•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•