843790 - Close tabs warning dialog misaligned with high dpi

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Jim Mathies [:jimm]]

Attachment: close tabs

See screen shot.

Comment 1

[Greg Edwards]

I can only replicate by setting my layout.css.devPixelsPerPx back to 1.0.
Which is a VERY GOOD REASON for why we should make -1.0 the default on Windows RIGHT NOW!

Comment 2

[Justin Dolske [:Dolske]]

Hmm. Guessing that something is causing the last word ("continue?") to wrap to a new line unexpectedly, which then pushes down the buttons.

Comment 3

[Greg Edwards]

The dialog seems to have a fixed pixel width which is responsible for the reflow since the text is proportionately larger.

Implementing Bug 820679 is the correct fix.

(The dialog's layout does appear to be fragile which could cause problems if a translation causes text to reflow.)

Comment 4

[Jonathan Kew [:jfkthame]]

(In reply to Greg Edwards from comment #1)
> I can only replicate by setting my layout.css.devPixelsPerPx back to 1.0.
> Which is a VERY GOOD REASON for why we should make -1.0 the default on
> Windows RIGHT NOW!

I've posted a patch in bug 844604 that would do this; I think we should go ahead with that change, and then see what fallout needs to be cleaned up, rather than worrying about stuff that is broken with the current default setting of 1.0, which we -know- is wrong (by design) for HiDPI environments.

Comment 5

[Jonathan Kew [:jfkthame]]

I can't reproduce this with current Nightly; presume (as per comments above) that bug 844604 was sufficient to fix it.

Comment 6

[Greg Edwards]

More particularly, Bug 852522 ought to have put this one away.