844219 - installing again an uninstalled packaged app is not displaying correctly the size

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Jason Smith [:jsmith]]

Build: B2G 18 2/22/2013
Device: Unagi

Note - Make sure you have a clean flashed build.

Steps:

1. Go to https://marketplace.firefox.com/app/sportv-futebol/
2. Install it - notice the download progress is determinate
3. Uninstall the app
4. Install that app again

Expected:

The download progress should be determinate in this case, as we know the size of the download.

Actual:

The download progress is indeterminate, even though we know the size of the download.

Additional Notes:

This is the bug I've been tried narrowing down for a while, but I finally got a consistent STR.

Comment 1

[Julien Wajsberg [:julienw]]

I think it happens with every packaged app with a size, and I may have a patch soon.

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: patch v1

- use updateManifest.size if there is an updateManifest, use manifest for the
  other properties if manifest is present
---
 apps/system/js/app_install_manager.js             |    9 ++-
 apps/system/test/unit/app_install_manager_test.js |   63 +++++++++++++++++++++
 2 files changed, 67 insertions(+), 5 deletions(-)


Asking for approval too : low risk, lots of unit tests, added some unit tests for this case too.

Comment 3

[Julien Wajsberg [:julienw]]

STR:
* install app in http://everlong.org/mozilla/selfupdatingpackaged/
* see in the notification panel that there is a determinate progress bar
* uninstall the app (no need to wait that it is installed)
* install the app again
* see in the notification panel that there is now an indeterminate a progress bar whereas it should be determined

Comment 4

[Julien Wajsberg [:julienw]]

master: https://github.com/mozilla-b2g/gaia/commit/7f0a1d5341ac8870e70f64f543ec79a729bf717e

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 719684 [details] [diff] [review]
patch v1

small changes with tests! <3

Comment 6

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 8b955ec03bb86187e2a21c5d24c0ff06e35324cb as:
v1-train: c2d63f7aac31bc35dec9c22224fe61bd5ee53853

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to John Ford [:jhford] from comment #6)
> Uplifted commit 8b955ec03bb86187e2a21c5d24c0ff06e35324cb as:
> v1-train: c2d63f7aac31bc35dec9c22224fe61bd5ee53853

sorry, wrong tab.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit 7f0a1d5341ac8870e70f64f543ec79a729bf717e as:
v1-train: 897f3b9ca9490cdddc9407033115b65cfcacf373