844239 - Robocop cleanup

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Geoff Brown [:gbrown]]

I want to cleanup the source code for Robocop tests -- make code formatting more uniform, etc.

Comment 1

[Geoff Brown [:gbrown]]

Attachment: indentation and file permissions

As a start, this replaces tabs with 4 space indents and removes execute permission from a few files.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 717248 [details] [diff] [review]
indentation and file permissions

Review of attachment 717248 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!

::: mobile/android/base/tests/testFormHistory.java.in
@@ +31,5 @@
>          Context context = (Context)getActivity();
>          ContentResolver cr = context.getContentResolver();
>          ContentValues[] cvs = new ContentValues[1];
>          cvs[0] = new ContentValues();
>    

nit, extra whitespace

@@ +102,1 @@
>    

nit, extra whitespace

::: mobile/android/base/tests/testPan.java.in
@@ +46,5 @@
>          int frames = mDriver.stopFrameRecording();
>          mAsserter.dumpLog("__start_report" + Integer.toString(frames) + "__end_report");
>          long msecs = System.currentTimeMillis();
>          mAsserter.dumpLog("__startTimestamp" + msecs + "__endTimestamp");
> +    }   

nit, extra whitespace

Comment 3

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb7a7827a9a6

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/cb7a7827a9a6

Comment 5

[Geoff Brown [:gbrown]]

Attachment: more indentation and spacing corrections; also consistent bracketing

Found some more!

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 718956 [details] [diff] [review]
more indentation and spacing corrections; also consistent bracketing

Review of attachment 718956 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for this.  I catch 9/10 simple style things, but there are always a few that sneak by!

Comment 7

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a7dec45d971d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a7dec45d971d

Comment 9

[Geoff Brown [:gbrown]]

Attachment: use blockForGeckoReady in testAwesomebarSwipes

I noticed testAwesomebarSwipes does not use blockForGeckoReady. Simply waiting for Gecko:Ready can lead to test failures (the event may be sent before the test starts).

While I was editing this, I noticed that the header comment was completely wrong -- wrote a new one.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 735952 [details] [diff] [review]
use blockForGeckoReady in testAwesomebarSwipes

Review of attachment 735952 [details] [diff] [review]:
-----------------------------------------------------------------

thanks, nice and simple.

Comment 11

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/269c92289bad

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/269c92289bad

Comment 13

[Geoff Brown [:gbrown]]

Attachment: specify charset in some rc test files

A few robocop html files do not specify the character encoding. afaik, this does not contribute to any test failures, but it does cause a warning seen in test logs:

[JavaScript Warning: "A form was submitted in the windows-1252 encoding which cannot encode all Unicode characters, so user input may get corrupted. To avoid this problem, the page should be changed so that the form is submitted in the UTF-8 encoding either by changing the encoding of the page itself to UTF-8 or by specifying accept-charset=utf-8 on the form element." {file: "http://mochi.test:8888/tests/robocop/robocop_login.html" line: 6}]

This patch specifies the charset as utf-8 in these files.

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 739817 [details] [diff] [review]
specify charset in some rc test files

Review of attachment 739817 [details] [diff] [review]:
-----------------------------------------------------------------

robocop will be an industry leader compared to all the other test suites we have!

Comment 15

[Geoff Brown [:gbrown]]

charset patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/5e085a3192ff

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5e085a3192ff

Comment 17

[Geoff Brown [:gbrown]]

I was going to use this bug for landing additional cleanup / restructuring patches, but others are taking up the cause now (bug 910791, etc).