844367 - move extensions/pref from mozilla-central to comm-central

Status: RESOLVED WONTFIX

(Core :: Preferences: Backend, defect)

Description

[Dana Keeler (she/her) [:keeler]]

As far as I can tell, the only consumer of anything in extensions/pref is the addon r2d2b2g in getLDAPAttributes, but this function isn't used (again, as far as I can tell).

Comment 1

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: Untested patch

Comment 2

[Dana Keeler (she/her) [:keeler]]

Attachment: patch

There were a few more things that needed removing (e.g. some instances of MOZ_PREF_EXTENSIONS) to get this to build. Once I made the changes, it just seemed easier to upload an updated patch.

Comment 3

[Dana Keeler (she/her) [:keeler]]

Attachment: interdiff

Interdiff

Comment 4

[Dana Keeler (she/her) [:keeler]]

Attachment: interdiff (unified)

Comment 5

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 717419 [details] [diff] [review]
patch

Ehsan, would you mind having a look at this? Thanks.

Comment 6

[(no longer active)]

Comment on attachment 717419 [details] [diff] [review]
patch

Review of attachment 717419 [details] [diff] [review]:
-----------------------------------------------------------------

This is used in comm-central, see <http://mxr.mozilla.org/comm-central/search?string=nsILDAPSyncQuery> for example.

Comment 7

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to :Ehsan Akhgari from comment #6)
> This is used in comm-central, see
> <http://mxr.mozilla.org/comm-central/search?string=nsILDAPSyncQuery> for
> example.

Is there any problem with moving it to comm-central?

I am planning to move a few "only used in comm-central" parts of PSM to comm-central.

Comment 8

[(no longer active)]

(In reply to comment #7)
> (In reply to :Ehsan Akhgari from comment #6)
> > This is used in comm-central, see
> > <http://mxr.mozilla.org/comm-central/search?string=nsILDAPSyncQuery> for
> > example.
> 
> Is there any problem with moving it to comm-central?
> 
> I am planning to move a few "only used in comm-central" parts of PSM to
> comm-central.

Not as far as I'm concerned, but this is really a question for the c-c folks.  :-)

Comment 9

[Dana Keeler (she/her) [:keeler]]

cc'ing some comm-central folks.

Comment 10

[Mark Banner (:standard8)]

Removing extensions/pref will break MCD (https://developer.mozilla.org/en-US/docs/MCD,_Mission_Control_Desktop_AKA_AutoConfig) which I know at least some enterprises rely on.

IMO this needs discussing on the enterprise lists before it could be removed.

Comment 11

[Dana Keeler (she/her) [:keeler]]

Thanks for the info, Mark. I'm updating the title of this bug to be more clear about what the current goal is.

Before I go any farther, though - does MCD actually still work with Firefox?

Comment 12

[Mark Banner (:standard8)]

Excluding the ldap part, last I knew MCD was still alive and kicking. If it is still working in TB, then there's no reason it won't still work in FF.

And to be honest, if we are removing it from FF, then I think we should consider the same in the TB communities as well.

Comment 13

[Benjamin Smedberg]

I really don't understand what this bug is about. extensions/pref implements enterprise preference control in Firefox. I absolutely despise the code, but it's certainly *used*, and removing it would be a product feature question.

Comment 14

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

It is just a misunderstanding. From our perspective, it looked like pure dead code and I had stumbled acrossed it when making other modifications. Then it looked like something only Thunderbird could use. Now, we see that that isn't the case. Nobody is proposing to remove a feature that is actually being used.