`cfx test` no longer works on Fennec

RESOLVED FIXED in 1.14

Status

P1
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: evold, Assigned: ochameau)

Tracking

unspecified
1.14
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee: nobody → poirot.alex
Severity: normal → critical
Priority: -- → P1
(Assignee)

Comment 1

6 years ago
Created attachment 717503 [details]
Pull request 811

I still need to test it extensively with all possible flag combination,
but that should fix mobile issue.

Obviously you identified a leak in my workflow as I'm not used to test on mobile... thanks a lot for doing it!!

So the issue was that cfx test for sdk modules depends on --overload-modules option which appears to be broken on device as we were using local filesystem paths for overload instead of remote device paths.
In this patch I upload SDK module on device and use device path instead.
Attachment #717503 - Flags: review?(evold)
(Assignee)

Comment 2

6 years ago
Just to tell that I've uploaded a new revision based on Erik's preliminary review.
Feel free to redirect this review to irakli if you are overloaded with private browsing stuffs.
Irakli can you review this one for us please?
Flags: needinfo?(rFobic)
Comment on attachment 717503 [details]
Pull request 811

Alex I think it's ok to land it as is, but we should probably include files into .xpi insntead of copying them one by one to the device. I'm ok with doing that in a followup change.
Attachment #717503 - Flags: review?(evold) → review+
Flags: needinfo?(rFobic)

Comment 5

6 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/403eb1f3ca19bdc33ba2da5c1b53a19e473baf52
Bug 844409: Implement proper support of --overload-modules for mobile.

https://github.com/mozilla/addon-sdk/commit/e91251e4348b3f6baf6303b0653eda64661d66be
Merge pull request #811 from ochameau/overload-mobile

Bug 844409: Implement proper support of --overload-modules for mobile. r=@gozala
(Assignee)

Comment 6

6 years ago
This patch would need to be cherry picked to stabilization otherwise cfx will fail working with fennec on 1.14
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.14
(Assignee)

Updated

6 years ago
Blocks: 846321

Comment 7

6 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/8c1756d635737ba97d94c84881b4c089b3968100
Merge pull request #811 from ochameau/overload-mobile

Bug 844409: Implement proper support of --overload-modules for mobile. r=@gozala(cherry picked from commit e91251e4348b3f6baf6303b0653eda64661d66be)

Comment 8

6 years ago
Commits pushed to integration at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/403eb1f3ca19bdc33ba2da5c1b53a19e473baf52
Bug 844409: Implement proper support of --overload-modules for mobile.

https://github.com/mozilla/addon-sdk/commit/e91251e4348b3f6baf6303b0653eda64661d66be
Merge pull request #811 from ochameau/overload-mobile
You need to log in before you can comment on or make changes to this bug.