844484 - context-menu image option should only accept valid URIs

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

At the moment one can set "foo" as the image property for a context-menu, which should not work.

Comment 1

[Sunny [:darkowlzz]]

Attachment: Link to pull request 974

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Sunny [:darkowlzz] from comment #1)
> Created attachment 742292 [details]
> Link to pull request 974

When you want a review, click on the details link for your attachment, and add a review ? for :gozala :ztatic :Mossop or :ZER0

Thanks!

Comment 3

[Sunny [:darkowlzz]]

Comment on attachment 742292 [details]
Link to pull request 974

Can you please run all the tests on your computer with this patch, just to see it didn't break anything? It fails on my computer with timeout even after increasing waiting time to 5 min but when tested only test-context-menu, it passed all the tests.

Thanks

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 742292 [details]
Link to pull request 974

cfx test -f context-menu passes for me.

Comment 5

[Sunny [:darkowlzz]]

Ready to be pulled :)

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/59ddf594706762ec3488045ae5f848d0032e10be
Merge pull request #974 from darkowlzz/bug844484

Fix Bug 844484 - context-menu image option should only accept valid URIs r=@erikvold

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

Thanks!

Comment 8

[Erik Vold [:erikvold] (please needinfo? me)]

Btw you can see the test results at https://tbpl.mozilla.org/?tree=Jetpack

Comment 9

[Sunny [:darkowlzz]]

Changing `ASSIGNED TO` to myself to make is easy to refer later.