Closed
Bug 844484
Opened 11 years ago
Closed 11 years ago
context-menu image option should only accept valid URIs
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evold, Assigned: darkowlzz)
References
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
At the moment one can set "foo" as the image property for a context-menu, which should not work.
Reporter | ||
Updated•11 years ago
|
Blocks: sdk/context-menu
Priority: -- → P2
Reporter | ||
Updated•11 years ago
|
Whiteboard: [good first bug]
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #742292 -
Attachment mime type: text/plain → text/html
Reporter | ||
Comment 2•11 years ago
|
||
(In reply to Sunny [:darkowlzz] from comment #1) > Created attachment 742292 [details] > Link to pull request 974 When you want a review, click on the details link for your attachment, and add a review ? for :gozala :ztatic :Mossop or :ZER0 Thanks!
Assignee | ||
Updated•11 years ago
|
Attachment #742292 -
Flags: review?(evold)
Reporter | ||
Updated•11 years ago
|
Attachment #742292 -
Flags: review?(evold) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 742292 [details]
Link to pull request 974
Can you please run all the tests on your computer with this patch, just to see it didn't break anything? It fails on my computer with timeout even after increasing waiting time to 5 min but when tested only test-context-menu, it passed all the tests.
Thanks
Attachment #742292 -
Flags: review+ → review?(evold)
Reporter | ||
Comment 4•11 years ago
|
||
Comment on attachment 742292 [details]
Link to pull request 974
cfx test -f context-menu passes for me.
Attachment #742292 -
Flags: review?(evold) → review+
Assignee | ||
Comment 5•11 years ago
|
||
Ready to be pulled :)
Comment 6•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/59ddf594706762ec3488045ae5f848d0032e10be Merge pull request #974 from darkowlzz/bug844484 Fix Bug 844484 - context-menu image option should only accept valid URIs r=@erikvold
Reporter | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 7•11 years ago
|
||
Thanks!
Reporter | ||
Comment 8•11 years ago
|
||
Btw you can see the test results at https://tbpl.mozilla.org/?tree=Jetpack
Blocks: 869687
Assignee | ||
Comment 9•11 years ago
|
||
Changing `ASSIGNED TO` to myself to make is easy to refer later.
Assignee: nobody → indiasuny000
You need to log in
before you can comment on or make changes to this bug.
Description
•