Closed
Bug 844573
Opened 12 years ago
Closed 12 years ago
newlines are displayed as spaces in landscape "full screen" textarea editor (Samsung keyboard)
Categories
(Firefox for Android Graveyard :: Keyboards and IME, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 23
People
(Reporter: jasa.david, Assigned: jchen)
Details
Attachments
(2 files, 1 obsolete file)
1.45 KB,
patch
|
masayuki
:
review+
|
Details | Diff | Splinter Review |
1.91 KB,
patch
|
cpeterson
:
review+
|
Details | Diff | Splinter Review |
newlines are displayed as spaces in landscape "full screen" textarea editor (Samsung keyboard)
Firefox: 19.0, 22.0a1 (2013-02-22)
OS: android 4.1.2
device: Samsung galaxy s iii mini (i8190)
The bug occurs consistently on all sites in firefox. I also checked opera mobile and it doesn't suffer from the bug.
Updated•12 years ago
|
Keywords: testcase-wanted
Comment 1•12 years ago
|
||
This is screen size dependent. On my G2 I get the full screen keyboard. I can reproduce the behavior however the text does end up correctly displayed once you exit the fullscreen keyboard. Gmail also uses the fullscreen keyboard however they use the multiline fullscreen keyboard.
Severity: normal → minor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: testcase-wanted
Hardware: Other → ARM
Comment 2•12 years ago
|
||
I guess something around here has to be changed:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoInputConnection.java#534
And it seems this has to be set somewhere:
http://developer.android.com/reference/android/text/InputType.html#TYPE_TEXT_FLAG_MULTI_LINE
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•12 years ago
|
||
Use "textarea" as input type
Attachment #732068 -
Flags: review?(masayuki)
Assignee | ||
Comment 4•12 years ago
|
||
Specify multiline flag for textarea and contentEditable/designMode documents
I also went ahead and reformatted the other lines
Attachment #732069 -
Flags: review?(cpeterson)
Comment 5•12 years ago
|
||
Comment on attachment 732069 [details] [diff] [review]
Detect textarea and fix up other input type flags (v1)
Review of attachment 732069 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM.
Please file a follow-up bug to handle mIMEModeHint for input types "textarea", "search", and (if applicable?) contenteditable. We should also add an explicit case for mIMEModeHint.equals("text") instead of relying on the final `else` to implicitly handle "text".
Attachment #732069 -
Flags: review?(cpeterson) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Patch to Just add textarea support. Going to refactor the rest of the code later.
Attachment #732069 -
Attachment is obsolete: true
Attachment #732108 -
Flags: review?(cpeterson)
Comment 7•12 years ago
|
||
Comment on attachment 732108 [details] [diff] [review]
Detect textarea (v2)
Review of attachment 732108 [details] [diff] [review]:
-----------------------------------------------------------------
+1
Attachment #732108 -
Flags: review?(cpeterson) → review+
Comment 8•12 years ago
|
||
Comment on attachment 732068 [details] [diff] [review]
Pass textarea input type (v1)
Sorry for the delay.
Attachment #732068 -
Flags: review?(masayuki) → review+
Assignee | ||
Comment 9•12 years ago
|
||
Comment 10•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0b5b5d9a8761
https://hg.mozilla.org/mozilla-central/rev/859e776239bf
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•