844573 - newlines are displayed as spaces in landscape "full screen" textarea editor (Samsung keyboard)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[David Jaša]

newlines are displayed as spaces in landscape "full screen" textarea editor (Samsung keyboard)

Firefox: 19.0, 22.0a1 (2013-02-22)
OS: android 4.1.2
device: Samsung galaxy s iii mini (i8190)

The bug occurs consistently on all sites in firefox. I also checked opera mobile and it doesn't suffer from the bug.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

This is screen size dependent. On my G2 I get the full screen keyboard. I can reproduce the behavior however the text does end up correctly displayed once you exit the fullscreen keyboard. Gmail also uses the fullscreen keyboard however they use the multiline fullscreen keyboard.

Comment 2

[Martijn Wargers (dead)]

I guess something around here has to be changed:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/GeckoInputConnection.java#534

And it seems this has to be set somewhere:
http://developer.android.com/reference/android/text/InputType.html#TYPE_TEXT_FLAG_MULTI_LINE

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Pass textarea input type (v1)

Use "textarea" as input type

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Detect textarea and fix up other input type flags (v1)

Specify multiline flag for textarea and contentEditable/designMode documents

I also went ahead and reformatted the other lines

Comment 5

[Chris Peterson [:cpeterson]]

Comment on attachment 732069 [details] [diff] [review]
Detect textarea and fix up other input type flags (v1)

Review of attachment 732069 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Please file a follow-up bug to handle mIMEModeHint for input types "textarea", "search", and (if applicable?) contenteditable. We should also add an explicit case for mIMEModeHint.equals("text") instead of relying on the final `else` to implicitly handle "text".

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Detect textarea (v2)

Patch to Just add textarea support. Going to refactor the rest of the code later.

Comment 7

[Chris Peterson [:cpeterson]]

Comment on attachment 732108 [details] [diff] [review]
Detect textarea (v2)

Review of attachment 732108 [details] [diff] [review]:
-----------------------------------------------------------------

+1

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 732068 [details] [diff] [review]
Pass textarea input type (v1)

Sorry for the delay.

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=f99765481c27

https://hg.mozilla.org/integration/mozilla-inbound/rev/0b5b5d9a8761
https://hg.mozilla.org/integration/mozilla-inbound/rev/859e776239bf

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0b5b5d9a8761
https://hg.mozilla.org/mozilla-central/rev/859e776239bf