844756 - Solve the problem of duplicate apps in Datazilla

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Comment 1

[Anthony Ricaud (:rik)]

Attachment: Proposed patch

That should do it.

Comment 2

[Guillermo López :willyaranda (probably SLOW response)]

This is not the patch :)

Comment 3

[Anthony Ricaud (:rik)]

Attachment: Proposed patch

Oops, thanks Guillermo.

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 718869 [details] [diff] [review]
Proposed patch

Review of attachment 718869 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should also change this in the |fullTitle| output.

::: tests/reporters/jsonmozperf.js
@@ +52,5 @@
>  
>    var self = this;
>    runner.on('end', function() {
> +    var [manifestPath, entryPoint] = window.mozTestInfo.appPath.split('/');
> +    self.stats.application = entryPoint || manifestPath;

I'd prefer to have this in an external function ?

Comment 5

[Anthony Ricaud (:rik)]

So I'm not sure we should only fix the issue for communications app. The main problem here is that b2gperf uses app name and |make test-perf| uses pathname.

Renaming to figure what's the best thing to do here. We should probably parse the manifest files to actually report app names.

Comment 6

[Anthony Ricaud (:rik)]

Discussed this with Julien a bit. One issue with using the app name is when we'll want to run those tests for other locales. If b2gperf relies on app names, it won't be able to run those.

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Won't we be able to launch using the localised name? CC'ing Jeads, who is going to hide apps from the list if the selected test has no data for them. In my opinion, this resolves the issue.

Comment 8

[Anthony Ricaud (:rik)]

We will be able to launch using the localised name, but that's just asking for trouble imho.

Anyway, the new datazilla visualisation resolves this. I'll just follow up by removing the "communications/" part because such a long name is ugly.

Comment 9

[Mike Lee [:mlee]]

Jonathan,

Is this still an issue that needs fixing or can it be closed?

Thanks,
Mike

Comment 10

[Jonathan Eads ( :jeads )]

My part in this bug was resolved in this release, Bug 846837, of the UI. I think this can be closed.

Comment 11

[Mike Lee [:mlee]]

Thanks Jonathan. Closing per comment 10.