844785 - xulrunner builds on nightly and aurora are only 46 bytes big

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[[e-mail] (:bhearsum)]

https://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/latest-mozilla-central/xulrunner-22.0a1.en-US.mac.tar.bz2
https://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/latest-mozilla-aurora/xulrunner-21.0a2.en-US.mac.tar.bz2

Make package shows:
Generate a DSA key pair ... 
/builds/slave/m-cen-osx64-xr-000000000000000/build/obj-firefox/i386/_virtualenv/bin/python /builds/slave/m-cen-osx64-xr-000000000000000/build/toolkit/mozapps/installer/find-dupes.py ../../dist/xulrunner
/builds/slave/m-cen-osx64-xr-000000000000000/build/obj-firefox/i386/config/nsinstall -D ../../dist/
/builds/slave/m-cen-osx64-xr-000000000000000/build/obj-firefox/i386/_virtualenv/bin/python /builds/slave/m-cen-osx64-xr-000000000000000/build/toolkit/mozapps/installer/informulate.py \
		../../dist//xulrunner-22.0a1.en-US.mac.json \
		BUILDID=20130225031141 \
		MOZ_SOURCE_REPO=http://hg.mozilla.org/mozilla-central \
		MOZ_SOURCE_STAMP=c233837cce08 \
		MOZ_PKG_PLATFORM=mac
Compressing...
cd ../../dist && gnutar -c --owner=0 --group=0 --numeric-owner --mode="go-w" --exclude=.mkdir.done -f - -C universal/xulrunner XUL.framework | bzip2 -vf > xulrunner-22.0a1.en-US.mac.tar.bz2
  (stdin): gnutar: XUL.framework: Cannot stat: No such file or directory

Comment 1

[[e-mail] (:bhearsum)]

I see this as far back as https://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/2013-01-30-03-09-07-mozilla-central/ (http://hg.mozilla.org/mozilla-central/rev/677e87c11252)

Before that, the builds were broken entirely (eg, not uploaded at all) since https://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/2013/01/2013-01-11-03-09-06-mozilla-central/ (http://hg.mozilla.org/mozilla-central/rev/8592c41069c2)

Before that, the builds were fine AFAICT: https://ftp.mozilla.org/pub/mozilla.org/xulrunner/nightly/2013/01/2013-01-10-03-09-39-mozilla-central/ (http://hg.mozilla.org/mozilla-central/rev/0a6e5a67c4e8)

I see that bug 835164 between the last missing build and the first one that's only 46b. Dunno if that's the cause or not since they were missing entirely for 2-3 weeks before that. cc'ing a few folks.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Fix xulrunner mac builds

The only line that really matters is the one in the packager.py command.

The other changes are just an unrelated cleanup and fixup.

The problem essentially is that with builds without a package manifest, _BINPATH was not used in the destination directory, while in cases with a package manifest, it is used indirectly by BINPATH being in the package manifest.

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 717879 [details] [diff] [review]
Fix xulrunner mac builds

Review of attachment 717879 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see any changes to packager.py in here, did you miss a part of the patch?

Comment 4

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #3)
> I don't see any changes to packager.py in here, did you miss a part of the
> patch?

That's really all there is. It changes the destination directory for builds without a package manifest.

Comment 5

[(not currently active) Ted Mielczarek]

Oh, sorry, I was just confused by:

(In reply to Mike Hommey [:glandium] from comment #2)
> The only line that really matters is the one in the packager.py command.

You meant in the *invocation* of packager.py.

Comment 6

[Alex Keybl [:akeybl]]

We may want to track this given our commitment to ensuring xulrunner is available at launch.

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/aaefec5d34f8

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 717879 [details] [diff] [review]
Fix xulrunner mac builds

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 780561
User impact if declined: Lack of xulrunner builds for mac.
Testing completed (on m-c, etc.): Landed on m-c a couple days ago. Fixed the xulrunner nightly and didn't break other builds.
Risk to taking this patch (and alternatives if risky): Low
String or UUID changes made by this patch: None

Comment 9

[bhavana bajaj [:bajaj]]

(In reply to Mike Hommey [:glandium] from comment #8)
> Comment on attachment 717879 [details] [diff] [review]
> Fix xulrunner mac builds
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): bug 780561
> User impact if declined: Lack of xulrunner builds for mac.
> Testing completed (on m-c, etc.): Landed on m-c a couple days ago. Fixed the
> xulrunner nightly and didn't break other builds.
> Risk to taking this patch (and alternatives if risky): Low
> String or UUID changes made by this patch: None

Can we please keep an eye to make sure this is not breaking other builds on Aurora, once this lands.Thanks !

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/92965b4677e5