Warn about the upcoming removal of multipart support in XHR

RESOLVED FIXED in Firefox 20

Status

()

Core
DOM
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: hsivonen, Assigned: hsivonen)

Tracking

unspecified
mozilla22
Points:
---

Firefox Tracking Flags

(firefox20 fixed, firefox21 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

4 years ago
Warn ahead of bug 843508.
(Assignee)

Comment 1

4 years ago
Created attachment 717835 [details] [diff] [review]
Add a warning
Attachment #717835 - Flags: review?(bugs)

Updated

4 years ago
Attachment #717835 - Flags: review?(bugs) → review+
(Assignee)

Comment 2

4 years ago
Thanks.

https://hg.mozilla.org/integration/mozilla-inbound/rev/e9e4dab21e79
https://hg.mozilla.org/mozilla-central/rev/e9e4dab21e79
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
(Assignee)

Comment 4

4 years ago
Comment on attachment 717835 [details] [diff] [review]
Add a warning

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 237319
User impact if declined: The removal of mostly unnecessary code is delayed. This patch adds an error console warning to give the one or two Web authors who use the feature an advance notice about the feature going away.
Testing completed (on m-c, etc.): Landed on m-c without problems.
Risk to taking this patch (and alternatives if risky): Extremely low risk (just logs a message).
String or UUID changes made by this patch: Adds one string. However, the string is an error console warning, so failure to translate is tolerable.
Attachment #717835 - Flags: approval-mozilla-aurora?
Are chunked response type going to be spec'ed and implemented by other browsers? It looks like it does not.
http://xhr.spec.whatwg.org/#interface-xmlhttprequest
I don't think it's a good idea to force Web developers to migrate once again.
(Assignee)

Comment 6

4 years ago
Good point. I'll follow up with a patch that recommends Web Sockets and Server-Sent Events but doesn't recommend chunked response.
CCing Axel here to weigh on the l10n impact . We think we should move fwd with the warning here .Pike what are the best options to deal with l10n here ?

Comment 8

4 years ago
My suggestion is to hard-code the string for aurora, and not expose it to l10n at all.
(Assignee)

Comment 9

4 years ago
Created attachment 719865 [details] [diff] [review]
Adjust warning text, make non-localizable
Attachment #719865 - Flags: review?(bugs)
Comment on attachment 719865 [details] [diff] [review]
Adjust warning text, make non-localizable

(though, I hope chunked data will be added to XHR spec)
Attachment #719865 - Flags: review?(bugs) → review+
(Assignee)

Comment 11

4 years ago
Thanks.
https://hg.mozilla.org/integration/mozilla-inbound/rev/90c0a4c5a4b6
(Assignee)

Updated

4 years ago
Attachment #717835 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 12

4 years ago
Created attachment 719957 [details] [diff] [review]
Merged patch for aurora

This patch combines the two patches landed on inbound, hence, carrying forward r+.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 237319
User impact if declined: The removal of mostly unnecessary code is delayed. This patch adds an error console warning to give the one or two Web authors who use the feature an advance notice about the feature going away.
Testing completed (on m-c, etc.): Trivial patch. Has landed.
Risk to taking this patch (and alternatives if risky): Extremely low risk (just logs a message).
String or UUID changes made by this patch: None. The log message is non-localizable.
Attachment #719957 - Flags: review+
Attachment #719957 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/90c0a4c5a4b6
Comment on attachment 719957 [details] [diff] [review]
Merged patch for aurora

Thanks for work around done for the l10n here :) Low risk patch, approving on aurora
Attachment #719957 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 15

4 years ago
Thanks. Landed on Aurora:
https://hg.mozilla.org/releases/mozilla-aurora/rev/feb9b4bac9ac
(Assignee)

Updated

4 years ago
status-firefox21: --- → fixed
(Assignee)

Comment 16

4 years ago
Comment on attachment 719957 [details] [diff] [review]
Merged patch for aurora

[Approval Request Comment]
See comment 12.

Can we uplift all the way to beta considering that this is extremely low risk and has no l10n impact?
Attachment #719957 - Flags: approval-mozilla-beta?
Comment on attachment 719957 [details] [diff] [review]
Merged patch for aurora

Approving since it's great to give 2 release warning (or close to it anyway) so let's get this into Beta 3 (ie: land to beta before tomorrow).
Attachment #719957 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
status-firefox20: --- → affected
(Assignee)

Comment 18

4 years ago
Thanks. Landed on beta:
https://hg.mozilla.org/releases/mozilla-beta/rev/ede329b80bc5

Updated

4 years ago
status-firefox20: affected → fixed
I've added this bug to the compatibility doc. Please correct the info if wrong.
https://developer.mozilla.org/en-US/docs/Site_Compatibility_for_Firefox_20
Component: DOM: Mozilla Extensions → DOM
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.