TSan: Thread data race in nsFactoryEntry::GetFactory() vs nsCOMPtr<nsIFactory>::get()

RESOLVED DUPLICATE of bug 684887

Status

()

--
critical
RESOLVED DUPLICATE of bug 684887
6 years ago
6 years ago

People

(Reporter: posidron, Unassigned)

Tracking

({sec-want})

Trunk
x86_64
Linux
sec-want
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [tsan][tsan-test-blocker])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Created attachment 717836 [details]
trace

During Firefox start-up with ThreadSanitizer (LLVM version), we get a data race reported as described in the attached log. Trace was created on mozilla-central with changeset c233837cce08.

According to the TSan devs, most of the reported traces should be real data races, even though they can be "benign". We need to determine if the race can/should be fixed, or put on the ignore list. Even for benign races, TSan devs suggest to fix them (second priority), as they can also cause problems [1].

[1] http://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-what-could-possibly-go-wrong
This could be a bug in networking stuff, given that 

    #6 nsStreamTransportService::Init() netwerk/base/src/nsStreamTransportService.cpp:441 (libxul.so+0x0000008b85ce)

is on the stack, using xpcom. Ccing some people for networking.
(Reporter)

Updated

6 years ago
QA Contact: general

Comment 2

6 years ago
This looks like the same race reported in bug 833349.
Very cool, thanks :) We'll wait for the patch in bug 684887 to land then.
Depends on: 684887

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 684887
You need to log in before you can comment on or make changes to this bug.